Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix typos in doc #3448

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Fix typos in doc #3448

merged 3 commits into from
Mar 26, 2021

Conversation

OliverShang
Copy link
Contributor

Fixed import errors in docs

@scarlett2018 scarlett2018 removed the request for review from kvartet March 17, 2021 03:02
@kvartet
Copy link
Contributor

kvartet commented Mar 17, 2021 •
edited
Loading

Hello @OliverShang, thanks for your contribution!
If it is convenient for you, please change all nni.feature_engineering to nni.algorithms.feature_engineering in the docs/en_US/FeatureEngineering/Overview.rst doc, and do not modify the Chinese doc, we will update it in other branch.

@OliverShang
Copy link
Contributor Author

Hello @OliverShang, thanks for your contribution!
If it is convenient for you, please change all nni.feature_engineering to nni.algorithms.feature_engineering in the docs/en_US/FeatureEngineering/Overview.rst doc, and do not modify the Chinese doc, we will update it in other branch.

Done that, but the FeatureSelector is indeed in nni.feature_engineering.feature_selector, so that part is unchanged.

@QuanluZhang QuanluZhang reopened this Mar 24, 2021
@SparkSnail SparkSnail merged commit 86d63a0 into microsoft:master Mar 26, 2021
@xmx-521 xmx-521 mentioned this pull request Apr 4, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ultmaster ultmaster ultmaster approved these changes

@scarlett2018 scarlett2018 scarlett2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OliverShang @kvartet @ultmaster @scarlett2018 @QuanluZhang @SparkSnail