Explicitly open winpty conin pipe in write-only mode - fixes #457 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find, @Eugeny - this fixes my usage of |
Tyriar
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the issue is caused by Node opening pipe sockets in RW mode by default.
One point to consider is whether the pipe should be
open()ed synchronously - however I'm pretty sure opening a named pipe is always instantaneous. Swapping it for an asynchronous open means initial writes would have to be buffered somewhere first.I've also added a test that fails on Node 14 with vanilla
node-ptyright now.Fixes #457