This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
add migration to fix notifications from pre-1.0.0 upgrade #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
approved these changes
Oct 12, 2020
ranweiler
reviewed
Oct 12, 2020
| @@ -48,3 +82,26 @@ def migrate(table_service: TableService, migration_names: List[str]) -> None: | |||
| print("applying migration '%s'" % name) | |||
| migrations[name](table_service) | |||
| print("migration '%s' applied" % name) | |||
|
|
|||
|
|
|||
| def main(): | |||
There was a problem hiding this comment.
It'd be nice to have some user-facing INFO-level logging so it is clear what's going on.
ranweiler
reviewed
Oct 12, 2020
|
|
||
| count = 0 | ||
| for entry in notifications: | ||
| try: |
There was a problem hiding this comment.
Could you add a comment about why this a non-exceptional UUID parse means we don't have to do anything?
ranweiler
reviewed
Oct 12, 2020
| @@ -38,8 +42,38 @@ def migrate_task_os(table_service: TableService) -> None: | |||
| print("migrated %s rows" % count) | |||
|
|
|||
|
|
|||
| def migrate_notification_keys(table_service: TableService) -> None: | |||
There was a problem hiding this comment.
We should maybe have much more explicit names and/or comments, including version info, for migration functions.
There was a problem hiding this comment.
Something to think about for the future.
ranweiler
approved these changes
Oct 12, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
In pre-1.0.0, notifications mapped notification_id to RowKey and Container to PartitionKey. In the 1.0.0 release, these got swapped causing pre-1.0.0 upgraded systems to fail.
PR Checklist
Info on Pull Request
A migration for pre-1.0.0 keys in the notifications table
Validation Steps Performed
How does someone test & validate?