This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add User Info to created tasks #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
approved these changes
Nov 12, 2020
ranweiler
approved these changes
Nov 12, 2020
|
Hello @bmc-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 10 hours 41 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, it looks like |
1 similar comment
|
Apologies, while this PR appears ready to be merged, it looks like |
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Nov 20, 2020
This adds information about the user that created a job or repro VM to the respective resources. This expands on the addition made to tasks in #303.
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes user information from JWT tokens available as part of a Task.
Included changes:
verify_tokentocall_if_agent, since this function is specific to agent token verificationis_authorizedtois_agent, since this function checks if the token is an agentis_agent(see start work towards enabling launching fuzzing within docker #133 for information)TaskConfigNote,
TaskConfigis what is provided to notification templates. This enables Github issues and ADO work items to tie back to the user that created the task.Note, while
upnusually means email for AAD user tokens. If we were going to make use of the email address, we should perform a graph lookup based on theoid, but we're not.