Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add a link to documentation on OOM task failure #3602

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kananb
Copy link
Contributor

@kananb kananb commented Oct 25, 2023

Summary of the Pull Request

Add more logging to OOM task failures, including a link to our docs on such events.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #3602 (71d870d) into main (d50fd48) will increase coverage by 1.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3602      +/-   ##
==========================================
+ Coverage   39.95%   41.02%   +1.06%     
==========================================
  Files         303      303              
  Lines       37724    37736      +12     
  Branches     1738     1738              
==========================================
+ Hits        15073    15481     +408     
+ Misses      22330    21934     -396     
  Partials      321      321              
Files Coverage Δ
src/agent/onefuzz-task/src/managed/cmd.rs 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

@kananb kananb marked this pull request as ready for review October 31, 2023 01:39
@kananb kananb requested a review from chkeita October 31, 2023 01:40
@kananb kananb changed the title Add room for a link to documentation on OOM task failure Add a link to documentation on OOM task failure Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants