Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TensorRT EP] support TensorRT 10-GA #20506

Merged
merged 14 commits into from
May 1, 2024
Merged

[TensorRT EP] support TensorRT 10-GA #20506

merged 14 commits into from
May 1, 2024

Conversation

yf711
Copy link
Contributor

@yf711 yf711 commented Apr 29, 2024 •
edited
Loading

Note: during each TRT major version update, lib.so version need to be updated in

onnxruntime/setup.py

Line 233 in 088e212

tensorrt_dependencies = ["libnvinfer.so.10", "libnvinfer_plugin.so.10", "libnvonnxparser.so.10"]

Description

This branch is based on rel-1.18.0 and supports TensorRT 10-GA.

Motivation and Context

@yf711 yf711 mentioned this pull request Apr 29, 2024
Closed
@jywu-msft
Copy link
Member

fix python lint please.

@jywu-msft
Copy link
Member

jywu-msft commented Apr 30, 2024 •
edited
Loading

seems like BIgModels CI pipeline is failing with this change
https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1367944&view=logs&j=d2b0c1d9-4e62-524d-3a74-a160559f53b0&t=031dd19e-2133-5c6e-94e1-c2be72532c05&l=657
it's trying to install libnvinfer? Did that pipeline previously run TensorRT EP? I thought it might have been for CUDA EP only

@yf711
Copy link
Contributor Author

yf711 commented Apr 30, 2024

seems like BIgModels CI pipeline is failing with this change https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1367944&view=logs&j=d2b0c1d9-4e62-524d-3a74-a160559f53b0&t=031dd19e-2133-5c6e-94e1-c2be72532c05&l=657 it's trying to install libnvinfer? Did that pipeline previously run TensorRT EP? I thought it might have been for CUDA EP only

Its dockerfile did install trt8.6 previously, so I updated it to trt10. Now the broken installation is fixed

@yf711 yf711 marked this pull request as ready for review April 30, 2024 19:39
@yf711 yf711 requested a review from a team as a code owner April 30, 2024 19:39
@jywu-msft jywu-msft added ep:TensorRT issues related to TensorRT execution provider release:1.18.0 labels May 1, 2024
@yf711 yf711 merged commit 2941776 into main May 1, 2024
91 of 94 checks passed
@yf711 yf711 deleted the yifanl/rel-1.18.0-trt10ga branch May 1, 2024 18:10
@sophies927 sophies927 added the triage:approved Approved for cherrypicks for release label May 1, 2024
@snnn snnn mentioned this pull request May 3, 2024
Merged
@jywu-msft jywu-msft restored the yifanl/rel-1.18.0-trt10ga branch May 4, 2024 03:59
jywu-msft pushed a commit that referenced this pull request May 4, 2024
@snnn
Update setup.py: update TRT version (#20557)
38412b6 
### Description
As a follow-up of #20506


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
@yihonglyu yihonglyu added the cherry-picked Cherry-picked for a cherrypicks branch label May 4, 2024
yihonglyu pushed a commit that referenced this pull request May 4, 2024
@yf711 @yihonglyu
[TensorRT EP] support TensorRT 10-GA (#20506)
8111dcd 
<!-- Describe your changes. -->
This branch is based on rel-1.18.0 and supports TensorRT 10-GA.

<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
yihonglyu pushed a commit that referenced this pull request May 4, 2024
@snnn @yihonglyu
Update setup.py: update TRT version (#20557)
a88b91d 
### Description
As a follow-up of #20506


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
TedThemistokleous pushed a commit to TedThemistokleous/onnxruntime that referenced this pull request May 7, 2024
@yf711
[TensorRT EP] support TensorRT 10-GA (microsoft#20506)
b5dcf68 
### Description
<!-- Describe your changes. -->
This branch is based on rel-1.18.0 and supports TensorRT 10-GA.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
TedThemistokleous pushed a commit to TedThemistokleous/onnxruntime that referenced this pull request May 7, 2024
@snnn
Update setup.py: update TRT version (microsoft#20557)
0a8785f 
### Description
As a follow-up of microsoft#20506


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
@yihonglyu yihonglyu added the rel-merged Cherrypicks merged into release label May 8, 2024
poweiw added a commit to poweiw/onnxruntime that referenced this pull request Jun 25, 2024
@poweiw
[TensorRT EP] support TensorRT 10-GA (microsoft#20506)
6d6df9e 
<!-- Describe your changes. -->
This branch is based on rel-1.18.0 and supports TensorRT 10-GA.

<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywu-msft jywu-msft jywu-msft approved these changes

Assignees
No one assigned
Labels
cherry-picked Cherry-picked for a cherrypicks branch ep:TensorRT issues related to TensorRT execution provider rel-merged Cherrypicks merged into release release:1.18.0 triage:approved Approved for cherrypicks for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yf711 @jywu-msft @yihonglyu @sophies927