Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete RoslynAnalyzers #21104

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Delete RoslynAnalyzers #21104

merged 1 commit into from
Jun 20, 2024

Conversation

snnn
Copy link
Member

@snnn snnn commented Jun 19, 2024

Description

Delete RoslynAnalyzers. Use CodeQL instead.

Motivation and Context

Now we already have CodeQL which is modern and also covers C# code. The RoslynAnalyzers one is not in our pull request pipelines. The "RoslynAnalyzers@2" task is outdated and needs be upgraded. I will delete it for now since we already have CodeQL.

@snnn snnn requested a review from a team as a code owner June 19, 2024 18:33
@snnn snnn merged commit 27f3ac7 into main Jun 20, 2024
149 of 156 checks passed
@snnn snnn deleted the snnn/csharp branch June 20, 2024 03:11
yf711 pushed a commit that referenced this pull request Jun 20, 2024
### Description
Delete RoslynAnalyzers. Use CodeQL instead.


### Motivation and Context
Now we already have CodeQL which is modern and also covers C# code. The
RoslynAnalyzers one is not in our pull request pipelines. The
"RoslynAnalyzers@2" task is outdated and needs be upgraded. I will
delete it for now since we already have CodeQL.
baijumeswani pushed a commit that referenced this pull request Jun 20, 2024
### Description
Delete RoslynAnalyzers. Use CodeQL instead.


### Motivation and Context
Now we already have CodeQL which is modern and also covers C# code. The
RoslynAnalyzers one is not in our pull request pipelines. The
"RoslynAnalyzers@2" task is outdated and needs be upgraded. I will
delete it for now since we already have CodeQL.
baijumeswani pushed a commit that referenced this pull request Jun 20, 2024
### Description
Delete RoslynAnalyzers. Use CodeQL instead.


### Motivation and Context
Now we already have CodeQL which is modern and also covers C# code. The
RoslynAnalyzers one is not in our pull request pipelines. The
"RoslynAnalyzers@2" task is outdated and needs be upgraded. I will
delete it for now since we already have CodeQL.
yf711 added a commit that referenced this pull request Jun 21, 2024
### Description
<!-- Describe your changes. -->
[#21062](#21062),
[#21096](#21096) to fix
Xamarin,

[#21095](#21095) and
[#21109](#21109) to fix
python on NuGet_Packaging stages

[#21104](#21104) to remove
failing roslynanalyzer on NuGet_Packaging stages

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

---------

Co-authored-by: Scott McKay <skottmckay@gmail.com>
Co-authored-by: Yi Zhang <zhanyi@microsoft.com>
Co-authored-by: Changming Sun <chasun@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants