fix: move onnxruntime import to function scope #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -7,19 +7,17 @@ | |||
| import abc | |||
| import contextlib | |||
| import pprint | |||
| import typing | |||
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from'
gramalingam
reviewed
Nov 29, 2022
|
|
||
| from onnxscript import autocast, irbuilder, onnx_opset, tensor, utils, values | ||
|
|
||
| if typing.TYPE_CHECKING: | ||
| import onnxruntime as ort |
There was a problem hiding this comment.
Just wondering: why is this necessary?
There was a problem hiding this comment.
This is for type annotation (for _cache_models). ort will be imported by type checkers but not in run time, so we don't fail if the environment doesn't have ort.
gramalingam
approved these changes
Nov 29, 2022
justinchuby
force-pushed
the
justinchu/evaluator
branch
from
238f0b4
to
23b7e9f
Compare
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 75.50% 75.50% -0.01%
==========================================
Files 89 89
Lines 7198 7201 +3
==========================================
+ Hits 5435 5437 +2
- Misses 1763 1764 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ort import into functions so onnx script still works without ort. This is also more friendly for new potential evaluators that do not require ORT.
fixes: #81