Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Add more task debug info in jobInfo api response [rest-server] #4667

Merged
merged 10 commits into from
Jul 7, 2020

Conversation

debuggy
Copy link
Contributor

@debuggy debuggy commented Jul 3, 2020

No description provided.

@coveralls
Copy link

coveralls commented Jul 3, 2020

Coverage Status

Coverage decreased (-0.08%) to 34.607% when pulling 0ee527a on mintao/rest-server-debuginfo into 55c83eb on master.

@debuggy debuggy marked this pull request as ready for review July 5, 2020 12:24
@debuggy debuggy changed the title Add more debug info in job detail Add more task debug info in jobInfo api response [rest-server] Jul 5, 2020
@scarlett2018 scarlett2018 mentioned this pull request Jul 5, 2020
47 tasks
@yqwang-ms

This comment has been minimized.

@yqwang-ms
Copy link
Member

yqwang-ms commented Jul 6, 2020

  virtualCluster,

Seems appExitType is useless and duplicated with appExitSpec, should we remove it?

BTW, the completionStatus.type.name only have 2 values;

type CompletionType struct {
 Name       CompletionTypeName        `json:"name" yaml:"name"`
 Attributes []CompletionTypeAttribute `json:"attributes" yaml:"attributes"`
}

type CompletionTypeName string

const (
 CompletionTypeNameSucceeded CompletionTypeName = "Succeeded"
 CompletionTypeNameFailed    CompletionTypeName = "Failed"
)


#Closed


Refers to: src/rest-server/src/models/v2/job/k8s.js:303 in 71c04eb. [](commit_id = 71c04eb, deletion_comment = False)

@debuggy
Copy link
Contributor Author

debuggy commented Jul 6, 2020

  virtualCluster,

Seems appExitType is useless and duplicated with appExitSpec, should we remove it?

BTW, the completionStatus.type.name only have 2 values;

type CompletionType struct {
 Name       CompletionTypeName        `json:"name" yaml:"name"`
 Attributes []CompletionTypeAttribute `json:"attributes" yaml:"attributes"`
}

type CompletionTypeName string

const (
 CompletionTypeNameSucceeded CompletionTypeName = "Succeeded"
 CompletionTypeNameFailed    CompletionTypeName = "Failed"
)

Refers to: src/rest-server/src/models/v2/job/k8s.js:303 in 71c04eb. [](commit_id = 71c04eb, deletion_comment = False)

If we delete a previous property, I am not sure any side effects on frontend. I have checked that webportal does not use this field, but still need to make sure sdk/vscode parts. #Closed

currentAttemptLaunchedTime:
type: integer
description: >-
the last attempt launched time, in number of milliseconds since the Unix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last attempt [](start = 24, length = 16)

current attempt launched time

Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@debuggy debuggy merged commit cf29f25 into master Jul 7, 2020
@scarlett2018 scarlett2018 mentioned this pull request Jul 16, 2020
39 tasks
@debuggy debuggy deleted the mintao/rest-server-debuginfo branch August 4, 2020 09:08
@scarlett2018 scarlett2018 mentioned this pull request Sep 10, 2020
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants