Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Job tagging #4853

Closed
wants to merge 25 commits into from
Closed

Job tagging #4853

wants to merge 25 commits into from

Conversation

suiguoxin
Copy link
Member

@suiguoxin suiguoxin commented Aug 28, 2020 •
edited
Loading

This PR is for part of issue #4789:

  • Alert-manager: Kill low-gpu-utilization jobs, tag abnormal jobs
    • add virtual cluster info in job-exporter
    • config monitor rules in prometheus
    • send action request through webhook
    • job-handler: deal with webhook request & redirect to RestServer
  • Job tags:
    • DB: job-tag table
    • RestServer: Refer to swagger for the new API.
      • getJobList : filter by tag
      • getJobDetails : with tag info
      • tag : put / delete
  • WebPortal abnormal jobs: refactor with tag filter
  • Cordon node with k8s API when GPU GCC Error

@suiguoxin suiguoxin marked this pull request as draft August 28, 2020 07:39
@coveralls
Copy link

coveralls commented Aug 28, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 34.493% when pulling cec1267 on suiguoxin:job-tag into d99ca9e on microsoft:master.

@suiguoxin suiguoxin force-pushed the job-tag branch 2 times, most recently from f9e34c4 to 8fd5eb4 Compare August 31, 2020 03:36
@suiguoxin suiguoxin mentioned this pull request Sep 1, 2020
Closed
@suiguoxin suiguoxin force-pushed the job-tag branch 2 times, most recently from a43ffbd to 2515f45 Compare September 3, 2020 03:21
hzy46
hzy46 reviewed Sep 3, 2020
View reviewed changes
src/rest-server/src/models/v2/job/k8s.js Outdated
tagsFilter.name.length,
),
});
filters.name = frameworkNames.reduce(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as above.

No such problem here.

src/rest-server/src/models/v2/job/k8s.js Outdated Show resolved Hide resolved
src/rest-server/src/models/v2/job/k8s.js Show resolved Hide resolved
@hzy46 hzy46 mentioned this pull request Sep 10, 2020
Closed
@shaiic-pai shaiic-pai mentioned this pull request Sep 18, 2020
Closed
@shaiic-pai shaiic-pai mentioned this pull request Sep 18, 2020
Closed
@suiguoxin suiguoxin mentioned this pull request Sep 18, 2020
Merged
@suiguoxin
Copy link
Member Author

Duplicated by #4924

@suiguoxin suiguoxin closed this Sep 22, 2020
@suiguoxin suiguoxin deleted the job-tag branch September 22, 2020 02:14
@suiguoxin suiguoxin mentioned this pull request Sep 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzy46 hzy46 hzy46 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suiguoxin @coveralls @hzy46