Skip to content

Commit

Permalink
feat(firefox): roll to r1403 (#22540)
Browse files Browse the repository at this point in the history
Fixes #22082
Fixes #20993
  • Loading branch information
aslushnikov authored Apr 22, 2023
1 parent 17df03c commit 99d4887
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions packages/playwright-core/browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
},
{
"name": "firefox",
"revision": "1399",
"revision": "1403",
"installByDefault": true,
"browserVersion": "112.0"
},
{
"name": "firefox-beta",
"revision": "1400",
"revision": "1404",
"installByDefault": false,
"browserVersion": "113.0b3"
},
Expand Down
6 changes: 2 additions & 4 deletions tests/library/headful.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ it('should not crash when creating second context', async ({ browser }) => {
}
});

it('should click when viewport size is larger than screen', async ({ page, browserName }) => {
it('should click when viewport size is larger than screen', async ({ page }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22082' });
it.fixme(browserName === 'firefox');
await page.setViewportSize({
width: 3000,
height: 3000,
Expand All @@ -81,9 +80,8 @@ it('should click when viewport size is larger than screen', async ({ page, brows
await page.locator('button').click();
});

it('should dispatch click events to oversized viewports', async ({ page, browserName }) => {
it('should dispatch click events to oversized viewports', async ({ page }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22082' });
it.fixme(browserName === 'firefox');
// Some prime numbers for width/height.
const width = 2971;
const height = 3067;
Expand Down
4 changes: 0 additions & 4 deletions tests/page/page-click.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ it('should select the text by triple clicking', async ({ page, server }) => {
});

it('should click offscreen buttons', async ({ page, server, browserName, headless }) => {
it.fixme(!headless && browserName === 'firefox' && process.platform === 'darwin', 'https://github.com/microsoft/playwright/issues/20993');

await page.goto(server.PREFIX + '/offscreenbuttons.html');
const messages = [];
page.on('console', msg => messages.push(msg.text()));
Expand Down Expand Up @@ -414,7 +412,6 @@ it('should click the button with em border with offset', async ({ page, server,
});

it('should click a very large button with offset', async ({ page, server, browserName }) => {

await page.goto(server.PREFIX + '/input/button.html');
await page.$eval('button', button => button.style.borderWidth = '8px');
await page.$eval('button', button => button.style.height = button.style.width = '2000px');
Expand All @@ -426,7 +423,6 @@ it('should click a very large button with offset', async ({ page, server, browse
});

it('should click a button in scrolling container with offset', async ({ page, server, browserName }) => {

await page.goto(server.PREFIX + '/input/button.html');
await page.$eval('button', button => {
const container = document.createElement('div');
Expand Down

0 comments on commit 99d4887

Please sign in to comment.