[BUG] browserType.launch: Protocol error (Browser.enable): Browser closed #11130

bpasero · 2021-12-29T16:27:42Z

Context:

Playwright Version: 1.17.1
Operating System: Mac
Node.js version: 14.x
Browser: All
Extra: Azure pipelines CI run

Code Snippet

playwright.chromium.launch();

Describe the bug

We had a failing Azure pipelines CI run in https://dev.azure.com/monacotools/Monaco/_build/results?buildId=148061&view=logs&j=3792f238-f35e-5f82-0dbc-272432d9a0fb&t=0d7e5bc9-922f-51dd-b06a-a90d0b9feeeb&l=13 with the following output printed:

Starting: Run unit tests (Browser, Chromium & Firefox & Webkit)
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /Users/runner/work/_temp/0b41947a-56e7-4f3d-ba2f-309cb70379dc.sh
yarn run v1.22.17
$ node test/unit/browser/index.js --build --browser chromium --browser webkit --browser firefox --tfs 'Browser Unit Tests'
browserType.launch: Protocol error (Browser.enable): Browser closed.
==================== Browser output: ====================
<launching> /Users/runner/Library/Caches/ms-playwright/firefox-1304/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-8oqYFV -juggler-pipe -silent
<launched> pid=11682
[pid=11682][err] *** You are running in headless mode.
=========================== logs ===========================
<launching> /Users/runner/Library/Caches/ms-playwright/firefox-1304/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-8oqYFV -juggler-pipe -silent
<launched> pid=11682
[pid=11682][err] *** You are running in headless mode.
============================================================
    at runTestsInBrowser (/Users/runner/work/1/s/test/unit/browser/index.js:127:48)
    at /Users/runner/work/1/s/test/unit/browser/index.js:239:17
    at /Users/runner/work/1/s/test/unit/browser/index.js:237:32 {
  name: 'Error'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
##[error]Bash exited with code '1'.
Finishing: Run unit tests (Browser, Chromium & Firefox & Webkit)

Asking here for advice if there is something we can do about it.

The text was updated successfully, but these errors were encountered:

aslushnikov · 2021-12-30T01:06:00Z

@bpasero I see this is Firefox crashing for you. A few questions:

does it happen reliably? If yes, can you please launch your tests with DEBUG=*browser* env variable?
do you have tracing / video recording enabled during this test run?

bpasero · 2021-12-30T07:16:50Z

@aslushnikov

does it happen reliably? If yes, can you please launch your tests with DEBUG=browser env variable

Not on every run, but maybe once per week we get this

do you have tracing / video recording enabled during this test run?

Yup we do. We start/stop tracing per unit test and only persist it on failure.

Would it make sense to always set DEBUG=*browser* for our CI? And how is the output generated, on std out?

Smrtnyk · 2021-12-30T07:28:16Z

I can confirm that I have the same issue and it happens just sometimes randomly, and only on firefox (we run chromium, webkit and ff)
I will observe when it happens again and collect the trace.

bpasero · 2021-12-30T10:29:25Z

It just happened again, we will probably have to disable Firefox to get non-flaky test runs.

Refs: microsoft/playwright#11130

aslushnikov · 2021-12-30T15:48:48Z

@bpasero we recently fixed a significant bug related to tracing in firefox that resulted in 72% of all the crashes we see. Can you please try running with @playwright/test@next?

bpasero · 2021-12-30T16:55:29Z

I would rather wait for a new official release from playwright if that is coming up soon?

aslushnikov · 2021-12-30T17:44:06Z

@bpasero scheduled for jan 2022!

aslushnikov · 2022-01-07T18:07:56Z

@bpasero we no longer think that we fixed it. Can you help us reproduce it? Maybe we can SSH into your hosted macOS runner and try reproduce it there?

bpasero · 2022-01-08T07:49:53Z

I do not think that is an option, after all this is our main Azure pipeline for building and we do not offer SSH access to that as far as I can tell for security reasons.

If there is some debug flags I can enable, please let me know.

Btw not sure if related, but in another run (not Firefox), I just got this now:

/bin/bash --noprofile --norc /Users/runner/work/_temp/62abe272-5a2a-4120-9451-c16d46ed8e96.sh
yarn run v1.22.17
$ node test/unit/browser/index.js --build --browser chromium --browser webkit --tfs 'Browser Unit Tests'
browserType.launch: Executable doesn't exist at /Users/runner/Library/Caches/ms-playwright/chromium-939194/chrome-mac/Chromium.app/Contents/MacOS/Chromium
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers:              ║
║                                                                         ║
║     npx playwright install                                              ║
║                                                                         ║
║ <3 Playwright Team                                                      ║
╚═════════════════════════════════════════════════════════════════════════╝
    at runTestsInBrowser (/Users/runner/work/1/s/test/unit/browser/index.js:127:48)
    at /Users/runner/work/1/s/test/unit/browser/index.js:239:17
    at /Users/runner/work/1/s/test/unit/browser/index.js:237:32 {
  name: 'Error'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
##[error]Bash exited with code '1'.
Finishing: Run unit tests (Browser, Chromium & Webkit)

aslushnikov · 2022-01-10T11:23:03Z

If there is some debug flags I can enable, please let me know.

@bpasero can you please setup a DEBUG=*browser* env variable when running firefox tests? It might give us some idea on what's going on.

microsoft/playwright#11130 (comment)

bpasero · 2022-01-10T16:17:06Z

@aslushnikov

2022-01-10T16:10:13.8531680Z ##[section]Starting: Run unit tests (Browser, Chromium & Firefox & Webkit)
2022-01-10T16:10:13.8549190Z ==============================================================================
2022-01-10T16:10:13.8549950Z Task         : Command line
2022-01-10T16:10:13.8550580Z Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
2022-01-10T16:10:13.8551130Z Version      : 2.182.0
2022-01-10T16:10:13.8551570Z Author       : Microsoft Corporation
2022-01-10T16:10:13.8552160Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
2022-01-10T16:10:13.8552780Z ==============================================================================
2022-01-10T16:10:14.3433170Z Generating script.
2022-01-10T16:10:14.3800670Z ========================== Starting Command Output ===========================
2022-01-10T16:10:14.4964720Z [command]/bin/bash --noprofile --norc /Users/runner/work/_temp/48c77c59-d5a4-4ec4-b9a4-c64f76b3bbd1.sh
2022-01-10T16:10:14.5808710Z yarn run v1.22.17
2022-01-10T16:10:14.8889950Z $ node test/unit/browser/index.js --build --browser chromium --browser webkit --browser firefox --tfs 'Browser Unit Tests'
2022-01-10T16:10:17.3027040Z 2022-01-10T16:10:17.242Z pw:browser <launching> /Users/runner/Library/Caches/ms-playwright/chromium-939194/chrome-mac/Chromium.app/Contents/MacOS/Chromium --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --enable-use-zoom-for-dsf=false --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --user-data-dir=/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_chromiumdev_profile-KwjDs1 --remote-debugging-pipe --no-startup-window
2022-01-10T16:10:17.3150720Z 2022-01-10T16:10:17.308Z pw:browser <launched> pid=3156
2022-01-10T16:10:17.3256480Z 2022-01-10T16:10:17.321Z pw:browser <launching> /Users/runner/Library/Caches/ms-playwright/webkit-1578/pw_run.sh --inspector-pipe --headless --no-startup-window
2022-01-10T16:10:17.6648040Z 2022-01-10T16:10:17.662Z pw:browser <launched> pid=3158
2022-01-10T16:10:17.6749600Z 2022-01-10T16:10:17.666Z pw:browser <launching> /Users/runner/Library/Caches/ms-playwright/firefox-1304/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-urNPC6 -juggler-pipe -silent
2022-01-10T16:10:17.6851470Z 2022-01-10T16:10:17.680Z pw:browser <launched> pid=3160
2022-01-10T16:10:45.4422180Z 2022-01-10T16:10:45.435Z pw:browser [pid=3156][err] [0110/161045.433718:ERROR:command_buffer_proxy_impl.cc(125)] ContextResult::kTransientFailure: Failed to send GpuControl.CreateCommandBuffer.
2022-01-10T16:10:47.2995660Z 2022-01-10T16:10:47.280Z pw:browser [pid=3158] <gracefully close start>
2022-01-10T16:10:47.4150720Z 2022-01-10T16:10:47.281Z pw:browser [pid=3160] <gracefully close start>
2022-01-10T16:10:47.4254840Z 2022-01-10T16:10:47.283Z pw:browser [pid=3158] <kill>
2022-01-10T16:10:47.4355540Z 2022-01-10T16:10:47.284Z pw:browser [pid=3158] <will force kill>
2022-01-10T16:10:47.4458970Z 2022-01-10T16:10:47.292Z pw:browser [pid=3160] <kill>
2022-01-10T16:10:47.5415510Z 2022-01-10T16:10:47.292Z pw:browser [pid=3160] <will force kill>
2022-01-10T16:10:47.5520390Z 2022-01-10T16:10:47.295Z pw:browser [pid=3158] <process did exit: exitCode=null, signal=SIGKILL>
2022-01-10T16:10:47.5624800Z 2022-01-10T16:10:47.295Z pw:browser [pid=3158] starting temporary directories cleanup
2022-01-10T16:10:47.5728120Z 2022-01-10T16:10:47.304Z pw:browser [pid=3160] <process did exit: exitCode=null, signal=SIGKILL>
2022-01-10T16:10:47.5831530Z 2022-01-10T16:10:47.304Z pw:browser [pid=3160] starting temporary directories cleanup
2022-01-10T16:10:47.5934600Z 2022-01-10T16:10:47.307Z pw:browser [pid=3158] finished temporary directories cleanup
2022-01-10T16:10:47.6035140Z 2022-01-10T16:10:47.307Z pw:browser [pid=3158] <gracefully close end>
2022-01-10T16:10:47.6257260Z browserType.launch: Timeout 30000ms exceeded.
2022-01-10T16:10:47.6360200Z =========================== logs ===========================
2022-01-10T16:10:47.6463720Z <launching> /Users/runner/Library/Caches/ms-playwright/webkit-1578/pw_run.sh --inspector-pipe --headless --no-startup-window
2022-01-10T16:10:47.6566280Z <launched> pid=3158
2022-01-10T16:10:47.6668640Z ============================================================
2022-01-10T16:10:47.6771790Z     at runTestsInBrowser (/Users/runner/work/1/s/test/unit/browser/index.js:127:48)
2022-01-10T16:10:47.6873550Z     at /Users/runner/work/1/s/test/unit/browser/index.js:239:17
2022-01-10T16:10:47.6975230Z     at /Users/runner/work/1/s/test/unit/browser/index.js:237:32 {
2022-01-10T16:10:47.7070200Z   name: 'TimeoutError'
2022-01-10T16:10:47.7170980Z }
2022-01-10T16:10:47.7273520Z 2022-01-10T16:10:47.616Z pw:browser [pid=3156] <kill>
2022-01-10T16:10:47.7376630Z 2022-01-10T16:10:47.616Z pw:browser [pid=3156] <will force kill>
2022-01-10T16:10:47.7478010Z 2022-01-10T16:10:47.628Z pw:browser [pid=3156] starting temporary directories cleanup
2022-01-10T16:10:47.7580470Z 2022-01-10T16:10:47.630Z pw:browser [pid=3156] finished temporary directories cleanup
2022-01-10T16:10:47.7679670Z error Command failed with exit code 1.
2022-01-10T16:10:47.7781540Z info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2022-01-10T16:10:47.9122840Z ##[error]Bash exited with code '1'.
2022-01-10T16:10:48.0583250Z ##[section]Finishing: Run unit tests (Browser, Chromium & Firefox & Webkit)

bpasero · 2022-01-10T16:19:05Z

Oh, maybe that is not a Firefox run actually, looks like webkit?

But I really like this output, is there any harm just always running with these debug environment variable for all our runs across all platforms?

aslushnikov · 2022-01-10T16:34:08Z

But I really like this output, is there any harm just always running with these debug environment variable for all our runs across all platforms?

@bpasero No harm, but it's spammy :)

I see all the browsers are launched in parallel which makes them fight for system resources. This might be fine on a very powerful hardware, but in general this is slow and unrecommended.

Any chance you can try running these tests serially instead?

bpasero · 2022-01-10T16:42:27Z

No that is not an option for us, because our builds are already very slow (more than 1h) and running tests in parallel was an explicit decision to speed up builds. We can always try to increase how beefy these machines are?

aslushnikov · 2022-01-10T17:56:55Z

We can always try to increase how beefy these machines are?

@bpasero yes, at least 2 CPU cores per browser. Or can you triple the machine count - and run one per browser? This is what we ourselves do.

bpasero · 2022-01-11T09:50:03Z

After discussion with team we have decided to stop running builds in parallel in our CI machines. Will report back how that goes over coming days.

iOnline247 · 2022-01-12T23:02:46Z

I do not think that is an option, after all this is our main Azure pipeline for building and we do not offer SSH access to that as far as I can tell for security reasons.

If there is some debug flags I can enable, please let me know.

Btw not sure if related, but in another run (not Firefox), I just got this now:

/bin/bash --noprofile --norc /Users/runner/work/_temp/62abe272-5a2a-4120-9451-c16d46ed8e96.sh
yarn run v1.22.17
$ node test/unit/browser/index.js --build --browser chromium --browser webkit --tfs 'Browser Unit Tests'
browserType.launch: Executable doesn't exist at /Users/runner/Library/Caches/ms-playwright/chromium-939194/chrome-mac/Chromium.app/Contents/MacOS/Chromium
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers:              ║
║                                                                         ║
║     npx playwright install                                              ║
║                                                                         ║
║ <3 Playwright Team                                                      ║
╚═════════════════════════════════════════════════════════════════════════╝
    at runTestsInBrowser (/Users/runner/work/1/s/test/unit/browser/index.js:127:48)
    at /Users/runner/work/1/s/test/unit/browser/index.js:239:17
    at /Users/runner/work/1/s/test/unit/browser/index.js:237:32 {
  name: 'Error'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
##[error]Bash exited with code '1'.
Finishing: Run unit tests (Browser, Chromium & Webkit)

This is happening to me as well, but I'm using chromium inside docker (mcr.microsoft.com/playwright:focal)

aslushnikov · 2022-01-13T00:14:46Z

@iOnline247 this error might happen in all kinds of situations. Would you mind filing a separate issue with a description of what's going on?

bpasero · 2022-01-14T06:33:06Z

Some new errors we see even after running sequentially:

From https://dev.azure.com/monacotools/Monaco/_build/results?buildId=150067&view=logs&j=3792f238-f35e-5f82-0dbc-272432d9a0fb&t=0d7e5bc9-922f-51dd-b06a-a90d0b9feeeb&l=15752

2022-01-13T21:39:22.2847110Z 2022-01-13T21:39:22.283Z pw:browser [pid=47133] <gracefully close start>
2022-01-13T21:39:22.3959850Z 2022-01-13T21:39:22.390Z pw:browser [pid=47133] <process did exit: exitCode=0, signal=null>
2022-01-13T21:39:22.4017810Z 2022-01-13T21:39:22.390Z pw:browser [pid=47133] starting temporary directories cleanup
2022-01-13T21:39:22.4305000Z 2022-01-13T21:39:22.429Z pw:browser [pid=47133] finished temporary directories cleanup
2022-01-13T21:39:22.4360920Z 2022-01-13T21:39:22.429Z pw:browser [pid=47133] <gracefully close end>
2022-01-13T21:39:22.4443200Z 2022-01-13T21:39:22.432Z pw:browser <launching> /Users/runner/Library/Caches/ms-playwright/firefox-1304/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-RJPM17 -juggler-pipe -silent
2022-01-13T21:39:22.4611970Z 2022-01-13T21:39:22.460Z pw:browser <launched> pid=47334
2022-01-13T21:39:24.4798180Z 2022-01-13T21:39:24.478Z pw:browser [pid=47334][err] *** You are running in headless mode.
2022-01-13T21:39:24.6038940Z 2022-01-13T21:39:24.603Z pw:browser [pid=47334] <gracefully close start>
2022-01-13T21:39:24.6154710Z 2022-01-13T21:39:24.604Z pw:browser [pid=47334] <kill>
2022-01-13T21:39:24.6257630Z 2022-01-13T21:39:24.604Z pw:browser [pid=47334] <will force kill>
2022-01-13T21:39:24.6361050Z 2022-01-13T21:39:24.605Z pw:browser [pid=47334] exception while trying to kill process: Error: kill EPERM
2022-01-13T21:39:24.6461320Z 2022-01-13T21:39:24.606Z pw:browser [pid=47334] <process did exit: exitCode=null, signal=SIGSEGV>
2022-01-13T21:39:24.6536600Z 2022-01-13T21:39:24.606Z pw:browser [pid=47334] starting temporary directories cleanup
2022-01-13T21:39:24.6640400Z 2022-01-13T21:39:24.609Z pw:browser [pid=47334] finished temporary directories cleanup
2022-01-13T21:39:24.6740720Z 2022-01-13T21:39:24.609Z pw:browser [pid=47334] <gracefully close end>
2022-01-13T21:39:24.6843300Z browserType.launch: Protocol error (Browser.enable): Browser closed.
2022-01-13T21:39:24.6943770Z ==================== Browser output: ====================
2022-01-13T21:39:24.7041210Z <launching> /Users/runner/Library/Caches/ms-playwright/firefox-1304/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-RJPM17 -juggler-pipe -silent
2022-01-13T21:39:24.7110600Z <launched> pid=47334
2022-01-13T21:39:24.7150970Z [pid=47334][err] *** You are running in headless mode.
2022-01-13T21:39:24.7213900Z =========================== logs ===========================
2022-01-13T21:39:24.7263210Z <launching> /Users/runner/Library/Caches/ms-playwright/firefox-1304/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-RJPM17 -juggler-pipe -silent
2022-01-13T21:39:24.7297850Z <launched> pid=47334
2022-01-13T21:39:24.7327300Z [pid=47334][err] *** You are running in headless mode.
2022-01-13T21:39:24.7340130Z ============================================================
2022-01-13T21:39:24.7362280Z     at runTestsInBrowser (/Users/runner/work/1/s/test/unit/browser/index.js:128:48)
2022-01-13T21:39:24.7386120Z     at /Users/runner/work/1/s/test/unit/browser/index.js:244:25 {
2022-01-13T21:39:24.7407960Z   name: 'Error'
2022-01-13T21:39:24.7428090Z }
2022-01-13T21:39:24.7445620Z error Command failed with exit code 1.
2022-01-13T21:39:24.7471980Z info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2022-01-13T21:39:24.7561960Z ##[error]Bash exited with code '1'.
2022-01-13T21:39:24.7582040Z ##[section]Finishing: Run unit tests (Browser, Chromium & Firefox & Webkit)

aslushnikov · 2022-01-14T10:54:21Z

process did exit: exitCode=null, signal=SIGSEGV

@bpasero and this now looks like something that was fixed! Let's see how it behaves with 1.18

bpasero · 2022-01-14T11:36:55Z

Nice, is that version planned to be released soon?

aslushnikov · 2022-01-14T14:11:35Z

@bpasero 1.18.0-rc1 was just released; would you mind giving it a try?

npm i @playwright/test@1.18.0-rc1

bpasero · 2022-01-14T16:31:01Z

Ok will try.

bpasero · 2022-01-14T17:12:15Z

I am getting weird compile errors now:

~/Development/Microsoft/monaco> yarn --cwd test/integration/browser compile
yarn run v1.22.17
$ tsc
../../../node_modules/@playwright/test/types/test.d.ts:18:13 - error TS1005: '=' expected.

18 import type { APIRequestContext, Browser, BrowserContext, BrowserContextOptions, Page, LaunchOptions, ViewportSize, Geolocation, HTTPCredentials } from 'playwright-core';
               ~

../../../node_modules/@playwright/test/types/test.d.ts:18:153 - error TS1005: ';' expected.

18 import type { APIRequestContext, Browser, BrowserContext, BrowserContextOptions, Page, LaunchOptions, ViewportSize, Geolocation, HTTPCredentials } from 'playwright-core';
                                                                                                                                                           ~~~~~~~~~~~~~~~~~

../../../node_modules/@playwright/test/types/test.d.ts:19:13 - error TS1005: '=' expected.

19 import type { Expect } from './testExpect';
               ~

../../../node_modules/@playwright/test/types/test.d.ts:19:29 - error TS1005: ';' expected.

19 import type { Expect } from './testExpect';
                               ~~~~~~~~~~~~~~

../../../node_modules/@playwright/test/types/test.d.ts:21:1 - error TS1128: Declaration or statement expected.

21 export type { Expect } from './testExpect';
   ~~~~~~

../../../node_modules/@playwright/test/types/test.d.ts:21:13 - error TS1005: ';' expected.

21 export type { Expect } from './testExpect';
               ~

../../../node_modules/@playwright/test/types/test.d.ts:21:29 - error TS1005: ';' expected.

21 export type { Expect } from './testExpect';
                               ~~~~~~~~~~~~~~


Found 7 errors.

error Command failed with exit code 2.

Did anything change besides the package having moved to @playwright/test?

You should be able to reproduce that from https://github.com/microsoft/vscode/tree/ben/playwright-1.18 with the command: yarn --cwd test/integration/browser compile

bpasero · 2022-01-15T07:27:30Z

Nevermind my above comment, I figured out a bad old TS dependency on our end.

bpasero · 2022-01-15T08:36:17Z

Pushed to main, will report back how it goes next week.

bpasero · 2022-01-19T15:56:16Z

Just came across this one:

2022-01-19T15:03:43.345Z pw:browser [pid=96985] <gracefully close start>
2022-01-19T15:03:43.520Z pw:browser [pid=96985] <process did exit: exitCode=0, signal=null>
2022-01-19T15:03:43.520Z pw:browser [pid=96985] starting temporary directories cleanup
2022-01-19T15:03:43.590Z pw:browser [pid=96985] finished temporary directories cleanup
2022-01-19T15:03:43.591Z pw:browser [pid=96985] <gracefully close end>
2022-01-19T15:03:43.601Z pw:browser <launching> /Users/runner/Library/Caches/ms-playwright/firefox-1313/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-85QEEK -juggler-pipe -silent
2022-01-19T15:03:43.627Z pw:browser <launched> pid=1198
2022-01-19T15:03:46.190Z pw:browser [pid=1198][err] *** You are running in headless mode.
2022-01-19T15:03:46.287Z pw:browser [pid=1198] <gracefully close start>
2022-01-19T15:03:46.288Z pw:browser [pid=1198] <kill>
2022-01-19T15:03:46.288Z pw:browser [pid=1198] <will force kill>
2022-01-19T15:03:46.289Z pw:browser [pid=1198] exception while trying to kill process: Error: kill EPERM
2022-01-19T15:03:46.289Z pw:browser [pid=1198] <process did exit: exitCode=null, signal=SIGSEGV>
2022-01-19T15:03:46.289Z pw:browser [pid=1198] starting temporary directories cleanup
2022-01-19T15:03:46.290Z pw:browser [pid=1198] finished temporary directories cleanup
2022-01-19T15:03:46.290Z pw:browser [pid=1198] <gracefully close end>
browserType.launch: Protocol error (Browser.enable): Browser closed.
==================== Browser output: ====================
<launching> /Users/runner/Library/Caches/ms-playwright/firefox-1313/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-85QEEK -juggler-pipe -silent
<launched> pid=1198
[pid=1198][err] *** You are running in headless mode.
=========================== logs ===========================
<launching> /Users/runner/Library/Caches/ms-playwright/firefox-1313/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/playwright_firefoxdev_profile-85QEEK -juggler-pipe -silent
<launched> pid=1198
[pid=1198][err] *** You are running in headless mode.
============================================================
    at runTestsInBrowser (/Users/runner/work/1/s/test/unit/browser/index.js:128:48)
    at /Users/runner/work/1/s/test/unit/browser/index.js:244:25 {
  name: 'Error'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

aslushnikov · 2022-02-03T18:52:22Z

@bpasero so I tried running firefox multiple times, though I can't repro this. How often does the error happen these days? Also, can you please share the parameters of your mac runner? Maybe I can get a similar setup and see if things will repro.

bpasero · 2022-02-04T06:23:05Z

We no longer run Firefox tests so I cannot answer that question.

Our Azure pipeline configuration is https://github.com/microsoft/vscode/blob/main/build/azure-pipelines/darwin/product-build-darwin.yml

aslushnikov · 2022-02-08T17:28:28Z

I so far still failed to repro this locally, but I'll try more!

@bpasero the azure pipeline you referred to has lots of secrets that are not accessible to me. Any instructions how to reproduce this locally as close as possible to your CI setup?

autotestwannabe · 2022-02-11T11:41:32Z

Is there any workaround to run tests on Firefox and Webkit? unable to launch on windows 10.... and npx playwright install is giving perm error.

browserType.launch: Executable doesn't exist at C:<>\AppData\Local\ms-playwright\firefox-1313\firefox\firefox.exe
browserType.launch: Executable doesn't exist at C:<>AppData\Local\ms-playwright\webkit-1596\Playwright.exe

╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ npx playwright install ║
║ ║
║ <3 Playwright Team ║
╚═════════════════════════════════════════════════════════════════════════╝

npx playwright install
Failed to install browsers
Error: Failed to download webkit v1596, caused by
Error: EPERM: operation not permitted, open 'C:<>\AppData\Local\ms-playwright\webkit-1596\Playwright.exe'

iOnline247 · 2022-02-15T22:14:47Z

Is there any workaround to run tests on Firefox and Webkit? unable to launch on windows 10.... and npx playwright install is giving perm error.

browserType.launch: Executable doesn't exist at C:<>\AppData\Local\ms-playwright\firefox-1313\firefox\firefox.exe browserType.launch: Executable doesn't exist at C:<>AppData\Local\ms-playwright\webkit-1596\Playwright.exe

╔═════════════════════════════════════════════════════════════════════════╗ ║ Looks like Playwright Test or Playwright was just installed or updated. ║ ║ Please run the following command to download new browsers: ║ ║ ║ ║ npx playwright install ║ ║ ║ ║ <3 Playwright Team ║ ╚═════════════════════════════════════════════════════════════════════════╝

npx playwright install Failed to install browsers Error: Failed to download webkit v1596, caused by Error: EPERM: operation not permitted, open 'C:<>\AppData\Local\ms-playwright\webkit-1596\Playwright.exe'

I pinned the version to 1.15.0 and it went away, FWIW.

aslushnikov · 2022-04-05T08:55:13Z

@bpasero: I'm happy to come back to this is there's a good repro that we can easily run & debug locally. Otherwise, we're out ideas!

Everybody: most of the other comments here seem to be unrelated to the bug discussed. Please, file separate issues!

jhanpiier · 2022-04-08T04:19:39Z

hello! I try to lift on a ubuntu server, but it gives me this error :((((

mxschmitt · 2022-04-08T08:21:57Z

hello! I try to lift on a ubuntu server, but it gives me this error :((((

You need to run it headless: true or with "xvfv-run npx playwright test".

jhanpiier · 2022-04-11T17:14:15Z

¡hola! Trato de levantar en un servidor ubuntu, pero me da este error :((((

Debe ejecutarlo sin cabeza: verdadero o con "prueba de dramaturgo xvfv-run npx".

@mxschmitt , It worked ! , but now I try to do it with dockers and it gives me an error, has it happened to you?

mxschmitt · 2022-04-11T17:26:11Z

Lets file a new issue please, since this one is unrelated and continues to spam others.

aslushnikov added the triaging label Dec 30, 2021

Smrtnyk mentioned this issue Dec 30, 2021

[Question] Run tests without exiting the process #11129

Closed

bpasero added a commit to microsoft/vscode that referenced this issue Dec 30, 2021

unit tests - disable firefox on macOS

4d4c4ac

Refs: microsoft/playwright#11130

pavelfeldman added v1.18 and removed triaging labels Jan 1, 2022

pavelfeldman assigned aslushnikov Jan 1, 2022

pavelfeldman added the P1-resolve-asap label Jan 1, 2022

bpasero added a commit to microsoft/vscode that referenced this issue Jan 10, 2022

tests - enable firefox testing again with debugging

baf7c08

microsoft/playwright#11130 (comment)

aslushnikov added v1.19 and removed v1.18 labels Jan 11, 2022

bpasero mentioned this issue Jan 14, 2022

Unit test failure at end of run microsoft/vscode#140713

Closed

bpasero mentioned this issue Jan 15, 2022

🆙 playwright@1.18 microsoft/vscode#140767

Merged

aslushnikov added v1.20 and removed P1-resolve-asap v1.19 labels Feb 8, 2022

aslushnikov added v1.21 and removed v1.20 labels Mar 1, 2022

mxschmitt added the browser-firefox label Mar 6, 2022

aslushnikov closed this as completed Apr 5, 2022

mxschmitt pinned this issue Apr 11, 2022

mxschmitt unpinned this issue Apr 11, 2022

microsoft locked and limited conversation to collaborators Apr 11, 2022

[BUG] browserType.launch: Protocol error (Browser.enable): Browser closed #11130

[BUG] browserType.launch: Protocol error (Browser.enable): Browser closed #11130

Comments

bpasero commented Dec 29, 2021

aslushnikov commented Dec 30, 2021

bpasero commented Dec 30, 2021

Smrtnyk commented Dec 30, 2021

bpasero commented Dec 30, 2021

aslushnikov commented Dec 30, 2021

bpasero commented Dec 30, 2021

aslushnikov commented Dec 30, 2021

aslushnikov commented Jan 7, 2022 • edited Loading

bpasero commented Jan 8, 2022

aslushnikov commented Jan 10, 2022

bpasero commented Jan 10, 2022 • edited Loading

bpasero commented Jan 10, 2022

aslushnikov commented Jan 10, 2022

bpasero commented Jan 10, 2022 • edited Loading

aslushnikov commented Jan 10, 2022

bpasero commented Jan 11, 2022

iOnline247 commented Jan 12, 2022

aslushnikov commented Jan 13, 2022

bpasero commented Jan 14, 2022 • edited Loading

aslushnikov commented Jan 14, 2022

bpasero commented Jan 14, 2022

aslushnikov commented Jan 14, 2022

bpasero commented Jan 14, 2022

bpasero commented Jan 14, 2022 • edited Loading

bpasero commented Jan 15, 2022

bpasero commented Jan 15, 2022

bpasero commented Jan 19, 2022

aslushnikov commented Feb 3, 2022

bpasero commented Feb 4, 2022

aslushnikov commented Feb 8, 2022

autotestwannabe commented Feb 11, 2022 • edited Loading

iOnline247 commented Feb 15, 2022

aslushnikov commented Apr 5, 2022

jhanpiier commented Apr 8, 2022

mxschmitt commented Apr 8, 2022

jhanpiier commented Apr 11, 2022

mxschmitt commented Apr 11, 2022

aslushnikov commented Jan 7, 2022 •

edited

Loading

bpasero commented Jan 10, 2022 •

edited

Loading

bpasero commented Jan 10, 2022 •

edited

Loading

bpasero commented Jan 14, 2022 •

edited

Loading

bpasero commented Jan 14, 2022 •

edited

Loading

autotestwannabe commented Feb 11, 2022 •

edited

Loading