Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Watch mode in UI Mode does not handle adding new test #22211

Closed
JonahKK opened this issue Apr 5, 2023 · 0 comments · Fixed by #31842
Closed

[BUG] Watch mode in UI Mode does not handle adding new test #22211

JonahKK opened this issue Apr 5, 2023 · 0 comments · Fixed by #31842
Assignees
@Skn0tt
Labels
feature-ui-mode

Comments

@JonahKK
Copy link
Contributor

JonahKK commented Apr 5, 2023

System info

  • Playwright Version: [v1.32.1]
  • Operating System: [macOS 13.2.1]
  • Other info: UI Mode

Steps

  • Open UI mode
  • Turn on Watch mode for one of the files.
  • Add a new test in that file.
  • Save the file

Expected

Watch mode should run the newly added test as well.

Actual

Watch mode runs only previously existing tests. The new test just appears in the list.
@pavelfeldman pavelfeldman self-assigned this Apr 5, 2023
@pavelfeldman pavelfeldman removed the v1.34 label May 4, 2023
@Skn0tt Skn0tt assigned Skn0tt and unassigned pavelfeldman Jul 23, 2024
Skn0tt added a commit to Skn0tt/playwright that referenced this issue Jul 24, 2024
@Skn0tt
write acceptance test for microsoft#22211
a41e566
@Skn0tt Skn0tt mentioned this issue Jul 24, 2024
Merged
Skn0tt added a commit that referenced this issue Jul 30, 2024
@Skn0tt
fix(ui): added test in watched file should be run (#31842)
8412d97 
Closes #22211

Currently, when the server notifies the UI about changed files, the UI
determines what files to re-run based on an old test list. By listing
tests before that, we make sure that the test list is up-to-date, and
that added tests are included in the next run.

I've also removed the `listChanged` event as discussed in the team sync.
The event isn't used anywhere and fires in exactly the same cases where
`testFilesChanged` fired, so i've folded them into one another. This allowed simplifying `Watcher`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skn0tt Skn0tt

Labels
feature-ui-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): added test in watched file should be run Skn0tt/playwright
4 participants
@pavelfeldman @yury-s @Skn0tt @JonahKK