Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): command to install chrome #20908

Closed
wants to merge 1 commit into from
Closed

fix(docs): command to install chrome #20908

wants to merge 1 commit into from

Conversation

laqieer
Copy link

@laqieer laqieer commented Feb 15, 2023

image

Signed-off-by: laqieer <laqieer@126.com>
@laqieer laqieer changed the title fix: command to install chrome fix(docs): command to install chrome Feb 15, 2023
@aslushnikov
Copy link
Collaborator

"msedge" or "chrome" is just an example value; either would work in the docs, so I don't think changing one to another is beneficial.

@laqieer
Copy link
Author

laqieer commented Feb 16, 2023

The point is not to change one to another, but to remove duplication. It is confused to see duplicated lines playwright install msedge. No idea why duplicates exist. After reading the source code, I guess they are for different shells, but they still look strange without any indication. It is better to add tab to indicate shell if they are for usage in different shells.

mxschmitt added a commit that referenced this pull request Feb 20, 2023
@mxschmitt
Copy link
Member

I followed-up in #21027 to fix it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants