feat(test runner): rework how tsconfig is applied #29882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Mar 11, 2024
This comment has been minimized.
This comment has been minimized.
Previously, test runner would load tsconfig for each imported file based on its location, going up the directory tree. Now, test runner mostly uses a single tsconfig for all imported files and respects `files`, `include` and `exclude` properties to determine whether to apply tsconfig to a particular file or not. For backwards compatibility, root tsconfig is used to load `playwright.config.ts`, but when `testDir` has its own tsconfig, it used for loading all tests instead of the root tsconfig.
dgozman
force-pushed
the
tr-single-tsconfig
branch
from
355da0d
to
cb676e2
Compare
Test results for "tests 1"7 flaky26966 passed, 631 skipped Merge workflow run. |
|
Archving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, test runner would load tsconfig for each imported file based on its location, going up the directory tree.
Now, test runner mostly uses a single tsconfig for all imported files and respects
files,includeandexcludeproperties to determine whether to apply tsconfig to a particular file or not.For backwards compatibility, root tsconfig is used to load
playwright.config.ts, but whentestDirhas its own tsconfig, it used for loading all tests instead of the root tsconfig.