Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not close the reused context when video is on #30807

Merged
merged 1 commit into from
May 15, 2024

Conversation

pavelfeldman
Copy link
Member

Fixes #30779

@@ -308,6 +308,7 @@ class TestServerDispatcher implements TestServerInterface {
reporter: params.reporters ? params.reporters.map(r => [r]) : undefined,
use: {
trace: params.trace === 'on' ? { mode: 'on', sources: false, _live: true } : (params.trace === 'off' ? 'off' : undefined),
video: 'off',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
video: 'off',
video: params.reuseContext ? 'off' : undefined,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed offline, video is primary and reuseContext is best effort here.

Copy link
Contributor

Test results for "tests 1"

27339 passed, 662 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 7a588e6 into microsoft:main May 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: VSCode extension closes browser after test
2 participants