Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#30820): fix(electron): allow launching with spaces in path #30830

Merged
merged 1 commit into from
May 15, 2024

Conversation

playwrightmachine
Copy link
Collaborator

This PR cherry-picks the following commits:

@mxschmitt mxschmitt merged commit 3867d55 into release-1.44 May 15, 2024
83 of 97 checks passed
@mxschmitt mxschmitt deleted the cherry-pick-1.44-2024-05-15-16-20-39 branch May 15, 2024 16:46
Copy link
Contributor

Test results for "tests 1"

26933 passed, 619 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

4 fatal errors, not part of any test
13 failed
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [firefox-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

59 flaky ⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-page] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [chromium-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [chromium-library] › library/capabilities.spec.ts:140:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [chromium-page] › page/page-event-request.spec.ts:139:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:210:5 › should work when owner frame detaches
⚠️ [firefox-page] › page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target
⚠️ [firefox-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-page] › page/page-screenshot.spec.ts:662:5 › page screenshot animations › should resume infinite animations
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [firefox-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:226:3 › should work when service worker is intefering
⚠️ [firefox-library] › library/har.spec.ts:393:3 › should filter by regexp
⚠️ [firefox-library] › library/hit-target.spec.ts:398:3 › should click in iframe with padding
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:138:7 › cli codegen › should upload multiple files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:200:7 › cli codegen › should download files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox-library] › library/trace-viewer.spec.ts:443:1 › should restore control values
⚠️ [firefox-library] › library/tracing.spec.ts:541:5 › should not hang for clicks that open dialogs
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium-library] › library/capabilities.spec.ts:140:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:24:7 › cli codegen › should contain open page
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:426:7 › cli codegen › should emit single keyup on ArrowDown
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:383:7 › cli codegen › should generate getByTestId
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:415:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:473:7 › cli codegen › should generate getByLabel
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:634:7 › cli codegen › should assert visibility
⚠️ [webkit-page] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [webkit-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [webkit-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
⚠️ [webkit-page] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

165655 passed, 7450 skipped, 2645 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants