Support for Formatting groups

[liprec]

As the current version of the powerbi-visuals-utils-formattingmodel does not support Formatting groups and to em that is one of the big improvements of the new formatting pane, I extended the current module to include the support for Formatting group.

Changelog

• Added support for creating custom Formatting groups
• Added extra attributes to Card, like missing topLevelToggle and disabled
• Add extra (optional) visible slice attribute for easier show/hide slices in a dynamic way
• Synced license in package.json to repo license

Please take the option to review this PR and I am open to discuss anything, like naming, structure etc.

Several points to discuss:

• class naming, like Group
• use/rename getFormattingGroup and getFormattingCard
• change version

[enema17484]

Would be great if this can be reviewed by the mandatory reviewers as it's a blocker to a lot of people's work

[liprec]

@ShereinDabbah I have updated the PR based on your comments, but three remarks are still open as I have questions for you.

[liprec]

@ShereinDabbah @AleksSavelev I have updated the PR based on the comments, but I still need to confirmation if it is OK to redefining the Card object and break any backwards compatibility? (see: #7 (comment))

[liprec]

@ShereinDabbah @AleksSavelev Any news on this PR?

[reyemb]

Thank you for your efforts and the time you've invested in putting this together. I've devoted considerable hours to this topic, and I must express some disappointment. When people are encouraged to participate, it can be disheartening when feedback is not forthcoming. The exchange of thoughts and comments are what keeps a community vibrant, so it's surprising to find that aspect lacking in this case.

[AleksSavelev]

A few suggestions from my side, but we should also wait for a review from @ShereinDabbah.

[KamranNaeem]

Will groups eventually be added to formattingModel?

[liprec]

@ShereinDabbah any news on the review of the PR 'Support for Formatting groups'?

[pochuanchan]

I also need this feature to develop my custom visual. Thank @liprec for the contribution and the PR. @ShereinDabbah could you please review it?
I have been waiting for this feature for a while. It is frustrating that powerbi-visuals-utils-formattingmodel doesn't support the formatting group as it should.

[M-Humza]

@ShereinDabbah Please do your job and review this. Assign this to another reviewer if you don't have the time. You have someone like @liprec doing awesome work and it's just sitting there for months. Groups should have been implemented in the formatting models in the first place.

[reyemb]

I've forked and incorporated liprec's pull request into a repository. To get started, you can install the package using:

npm install powerbi-visuals-utils-formattingmodel-community

Find the repository here:
GitHub Repository

This version allows the use of formattingGroups. A simple example to illustrate how to implement this feature is available here:

Demo Repository

For implementation details, refer to the src/settings.ts file in the demo repository.

A big shout-out to liprec

[Vivaldi4S]

@reyemb You are a life saver. Thank you so much! Also, thank you @liprec for all your awesome work

[ShereinDabbah]

Thanks @liprec , I approved the PR after all comments were fixed.
@AleksSavelev Please can you check last comment from @liprec

[AleksSavelev]

@liprec
Please, rebase your branch and run npm audit fix to fix audit warnings.

And I'm ready to merge and publish it. Thank you a lot for your patience and cooperation!

[liprec]

@AleksSavelev I will rebase and solve the npm audit issues, but how do we handle the open backward compatibility comment: #7 (comment)

Keep the export type Cards = SimpleCard | CompositeCard; ?

[liprec]

Should be good to go @AleksSavelev and @ShereinDabbah 🚀

[AleksSavelev]

Thanks to everyone, especially @liprec! I'll publish it in the upcoming few days

[M-Humza]

Thanks to everyone, especially @liprec! I'll publish it in the upcoming few days

Will this community version of the formattingmodel be viable for publishing the visual?

[AleksSavelev]

Thanks to everyone, especially @liprec! I'll publish it in the upcoming few days

Will this community version of the formattingmodel be viable for publishing the visual?

A new version of powerbi-visuals-utils-formattingmode@6.0.0l is published. It includes all the changes from this PR.

Is there any reason why you want to use the community version instead?

[M-Humza]

Thanks to everyone, especially @liprec! I'll publish it in the upcoming few days

Will this community version of the formattingmodel be viable for publishing the visual?

A new version of powerbi-visuals-utils-formattingmode@6.0.0l is published. It includes all the changes from this PR.

Is there any reason why you want to use the community version instead?

I didn't know that was published. Thank you for informing me. I appreciate all your efforts and your time!