Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devkit][bugfix] Add missing user agent in trace telemetry #3421

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Jun 17, 2024

Description

Add user_agent in trace telemetry, so that we can distinguish different SDK version from the telemetry.

image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Jun 17, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/add-user-agent

  4 files    4 suites   4m 20s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit fa8f76b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 17, 2024

SDK CLI Global Config Test Result zhengfei/bugfix/add-user-agent

6 tests   6 ✅  1m 18s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit fa8f76b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 17, 2024

Executor Unit Test Result zhengfei/bugfix/add-user-agent

796 tests   796 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit fa8f76b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 17, 2024

Executor E2E Test Result zhengfei/bugfix/add-user-agent

246 tests   238 ✅  5m 1s ⏱️
  1 suites    6 💤
  1 files      2 ❌

For more details on these failures, see this check.

Results for commit fa8f76b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 17, 2024

SDK CLI Test Result zhengfei/bugfix/add-user-agent

    4 files      4 suites   1h 6m 4s ⏱️
  786 tests   766 ✅ 20 💤 0 ❌
3 144 runs  3 064 ✅ 80 💤 0 ❌

Results for commit fa8f76b.

♻️ This comment has been updated with latest results.

@zhengfeiwang zhengfeiwang merged commit 604f4a4 into main Jun 18, 2024
39 of 41 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/add-user-agent branch June 18, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants