Add support for upward conversion in facade_builder::add_facade
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tian-lt
reviewed
Sep 4, 2024
tian-lt
reviewed
Sep 4, 2024
|
Add a test to cover the case of prevent from implicit upward conversion with |
tian-lt
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
facade_builder::add_facadedoes not generate conventions for implicit upward conversion to guarantee minimum binary size. However, upward conversion is helpful when an API requires backward compatibility. With this change, users can opt-in this feature by specifyingtrueas the second parameter offacade_builder::add_facade, at the cost of potentially a little bit larger binary size.4 unit test cases are added for this change.