Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro PRO_DEF_COMBINED_DISPATCH #54

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Jan 3, 2024

Work item: #53

A new macro PRO_DEF_COMBINED_DISPATCH is added in this change to allow overload resolution among multiple existing dispatches. Some constraints of arguments are added to the operator() of PRO_DEF_MEMBER_DISPATCH and PRO_DEF_FREE_DISPATCH to support arbitrary combination of dispatches defined with these 2 macros. Updated unit test case ProxyInvocationTests.TestOverloadResolution accordingly.

@mingxwa mingxwa requested a review from tian-lt January 3, 2024 16:04
Copy link
Member

@guominrui guominrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proxy.h Show resolved Hide resolved
proxy.h Show resolved Hide resolved
@mingxwa mingxwa merged commit 67cdc89 into microsoft:main Jan 4, 2024
4 checks passed
@mingxwa mingxwa deleted the user/mingxwa/def-combination branch January 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants