Resolve review comments of P3086R1 from the ISO C++ committee #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per review comments of P3086R1, two design issues were raised. More details of the review are documented here. The two issues are:
concept facade
should expecttuple-like
types rather than specializations ofstd::tuple
to stay consistency with the existing standard.make_proxy
lacks allocator support. Sinceproxy
does not rely on this facility, splitting into a separate paper is recommended.For 1, the implementation of was updated in this change to accept any
tuple-like
types inconcept facade
,PRO_DEF_FACADE
andproxy
. Another case was added in tests/proxy_traits_tests.cpp.For 2, a new API
allocate_proxy
was added in this change. 15 new cases were added in tests/proxy_creation_tests.cpp.Closes #74
Closes #75