Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve review comments of P3086R1 from the ISO C++ committee #76

Merged
merged 13 commits into from
Mar 26, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Mar 20, 2024

As per review comments of P3086R1, two design issues were raised. More details of the review are documented here. The two issues are:

  1. the semantics of concept facade should expect tuple-like types rather than specializations of std::tuple to stay consistency with the existing standard.
  2. make_proxy lacks allocator support. Since proxy does not rely on this facility, splitting into a separate paper is recommended.

For 1, the implementation of was updated in this change to accept any tuple-like types in concept facade, PRO_DEF_FACADE and proxy. Another case was added in tests/proxy_traits_tests.cpp.

For 2, a new API allocate_proxy was added in this change. 15 new cases were added in tests/proxy_creation_tests.cpp.

Closes #74
Closes #75

@mingxwa mingxwa changed the title User/mingxwa/committee comments Resolve review comments of P3086R1 from the ISO C++ committee Mar 24, 2024
@mingxwa mingxwa marked this pull request as ready for review March 24, 2024 14:23
@mingxwa mingxwa merged commit 5345b26 into microsoft:main Mar 26, 2024
4 checks passed
@mingxwa mingxwa deleted the user/mingxwa/committee-comments branch March 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants