files for adafruit grand central #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelikhan
reviewed
Jan 19, 2021
|
Are there any more files that need to be modified in common packages? |
|
There's a comment on that PR that needs to be addressed microsoft/pxt-common-packages#1207 (comment) |
guriaregojo
added a commit
to guriaregojo/pxt-common-packages
that referenced
this pull request
Jan 19, 2021
on behalf of @wallarug. Part 3 of 3. changes for the platform.h in common packages See: microsoft#1207 For rest of files: microsoft/pxt-maker#329
mmoskal
pushed a commit
to microsoft/pxt-common-packages
that referenced
this pull request
Jan 20, 2021
* Updated pull request (1207) platform.h on behalf of @wallarug. Part 3 of 3. changes for the platform.h in common packages See: #1207 For rest of files: microsoft/pxt-maker#329 * Update platform.h
|
Hey everyone on this ticket. What extra steps need to be taken to have this pushed through? What is the microsoft makecode team waiting on? Thanks |
|
great! seems to be working thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the files