Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time machine updates #9693

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Time machine updates #9693

merged 4 commits into from
Sep 22, 2023

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Sep 21, 2023

This pr does a few things:

  1. New time machine design with a tree view instead of a slider
  2. Time machine is now "See Version History" and lives next to the other project things in the cogwheel
  3. Reduces the history interval to once every 5 minutes
  4. Adds a "save a copy" button to the time machine page

image

image

@riknoll riknoll requested a review from a team September 21, 2023 22:45
Copy link
Contributor

@eanders-ms eanders-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riknoll riknoll merged commit 8b2f251 into master Sep 22, 2023
6 checks passed
@riknoll riknoll deleted the time-machine-ui branch September 22, 2023 16:56
@THEb0nny
Copy link
Contributor

THEb0nny commented Feb 7, 2024

@riknoll I added timemachine to pxt-ev3 and noticed a problem, it can also be seen in arcade. I created a new project and in the change history I see the word Yesterday with the Russian language turned on. I switch to English and it comes out there today. I checked in Crowdin this is not a translation error. the word Yesterday actually comes out there.

@riknoll
Copy link
Member Author

riknoll commented Feb 8, 2024

hmmmmm... not sure what that could be. the time machine doesn't really pay attention to the locale. i'll try and fiddle with it when i get a chance.

@riknoll
Copy link
Member Author

riknoll commented Feb 8, 2024

in the meantime, can you file an issue in pxt-arcade and tag me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants