Fix various docs/homepage accessibility bugs #9974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of small accessibility bugs. Each commit is a single fix, so you can also review it one by one if that helps.
Fixes microsoft/pxt-microbit#5495
Fixes microsoft/pxt-arcade#4865
Fixes microsoft/pxt-arcade#4868
Fixes microsoft/pxt-microbit#5466
Fixes microsoft/pxt-arcade#3969
Fixes microsoft/pxt-microbit#5473
Does the following:
@locale@
gulp pxtrunner
shortcut for compiling just pxtrunner (much likegulp webapp
)In regards to the
@locale@
change, the backend wasn't patching this with anything (it was returning the empty string) so I'm not sure how this was supposed to work. We also use this on index.html, but it seems like it always returnsen
regardless of what my browser locale is or what I pass as a query parameter. Rather than debug this, I opted to just hardcode it toen
which is what we do in most of our other webapps anyhow and seems to be the only thing the backend ever returns.