Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various docs/homepage accessibility bugs #9974

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Apr 16, 2024

This PR fixes a bunch of small accessibility bugs. Each commit is a single fix, so you can also review it one by one if that helps.

Fixes microsoft/pxt-microbit#5495
Fixes microsoft/pxt-arcade#4865
Fixes microsoft/pxt-arcade#4868
Fixes microsoft/pxt-microbit#5466
Fixes microsoft/pxt-arcade#3969
Fixes microsoft/pxt-microbit#5473

Does the following:

  1. Adds underlines to links within paragraphs in docs pages
  2. Adds a title attribute to simulator frames embedded in docs pages
  3. Sets the lang on docs html pages to "en" instead of @locale@
  4. Gives the carousel arrows on the homepage an outline when focused
  5. Marks landmark roles on the docs pages
  6. Adds a gulp pxtrunner shortcut for compiling just pxtrunner (much like gulp webapp)

In regards to the @locale@ change, the backend wasn't patching this with anything (it was returning the empty string) so I'm not sure how this was supposed to work. We also use this on index.html, but it seems like it always returns en regardless of what my browser locale is or what I pass as a query parameter. Rather than debug this, I opted to just hardcode it to en which is what we do in most of our other webapps anyhow and seems to be the only thing the backend ever returns.

@riknoll riknoll requested a review from a team April 16, 2024 21:31
Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riknoll riknoll merged commit d13b8a3 into master Apr 16, 2024
7 checks passed
@riknoll riknoll deleted the dev/riknoll/accessible-docs branch April 16, 2024 21:45
riknoll added a commit that referenced this pull request Apr 16, 2024
riknoll added a commit that referenced this pull request Apr 16, 2024
* Revert "Fix various docs/homepage accessibility bugs (#9974)"

This reverts commit d13b8a3.

* Revert "Fix TOC header and card list roles in docs (#9971)"

This reverts commit 948b36f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment