Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False negative for callback protocols that accept *args #4414

Closed
erictraut opened this issue Jan 6, 2023 · 1 comment
Closed

False negative for callback protocols that accept *args #4414

erictraut opened this issue Jan 6, 2023 · 1 comment
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request

Comments

@erictraut
Copy link
Collaborator

The following should generate an error.

from typing import Any, Protocol

class Proto(Protocol):
    def __call__(self, x: int, *args: Any) -> int:
        return 0

def func1(x: int, s: str) -> int:
    return 0

x: Proto = func1
@erictraut erictraut added the enhancement request New feature or request label Jan 6, 2023
erictraut pushed a commit that referenced this issue Jan 7, 2023
@msfterictraut
Fixed a bug that led to a false negative when comparing a function wi…
c7ed87e 
…thout a `*args` to a callable type with a `*args`. This addresses #4414.
@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label Jan 7, 2023
@erictraut
Copy link
Collaborator Author

This is addressed in pyright 1.1.288, which I just published. It will also be included in a future release of pylance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erictraut