-
Notifications
You must be signed in to change notification settings - Fork 56
Fixing incorrect rendering of pipe character #115
Conversation
@bettinaheim @tcNickolas @cgranade Could you review this? Thanks! |
This approach doesn't seem to work when viewing the files on GitHub: looking at https://github.com/microsoft/qsharp-language/blob/740b3427d7be2f8bcba1e9c14675d82b16590143/Specifications/Language/3_Expressions/PrecedenceAndAssociativity.md, it renders as |
@tcNickolas I have changed it for another of the possible solutions. This one renders ok on GitHub files, hope it does on the docs page too. |
Can you open a pull request with a matching change on the docs repo so that we get a preview to check whether this solution works indeed? |
Hi @tcNickolas. I have created this matching PR, in the preview we see that the pipe character is rendering ok :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks like this solution works both on GitHub and in the docs!
Just one small comment: let's keep the whitespace between ? and |, since they are not a single operator like |||, but rather two parts of an operator that have an expression between them.
Specifications/Language/3_Expressions/PrecedenceAndAssociativity.md
Outdated
Show resolved
Hide resolved
…ty.md Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@bettinaheim could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I believe this is addressed by the now merged PR #124. I'll hence close this. |
This closes #352