-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatter Indentation and Delimiter Logic #1289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 5a0761dClick to view benchmark
|
ScottCarda-MS
requested review from
idavis,
minestarks and
swernli
as code owners
March 21, 2024 17:18
ScottCarda-MS
changed the title
Formatter Indentation Logic
Formatter Indentation and Delimiter Logic
Mar 21, 2024
I've run this version of the formatter against the samples and library files to test that nothing unreasonable or unexpected occurs. I don't want to add the updated samples/libraries to this PR though, as I think that would be better for a future PR where I could include running the formatter automatically in the build pipeline. |
minestarks
reviewed
Mar 21, 2024
minestarks
reviewed
Mar 21, 2024
minestarks
reviewed
Mar 21, 2024
minestarks
reviewed
Mar 21, 2024
minestarks
reviewed
Mar 21, 2024
Benchmark for aa9f996Click to view benchmark
|
minestarks
approved these changes
Mar 21, 2024
Benchmark for 5c3ee78Click to view benchmark
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some state to the formatter for the purposes of better handling of delimiters, i.e.
[]
,()
,{}
, and type parameter list delimiters<>
. The formatting of delimited blocks will be determined by whether there is a newline in the whitespace following the open delimiter.