Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default level of the DivisionByZero lint to "error" #1445

Merged
merged 4 commits into from
May 1, 2024

Conversation

orpuente-MS
Copy link
Contributor

@orpuente-MS orpuente-MS commented Apr 29, 2024

It is confusing that a division by zero causes a runtime error, but its default lint level is "warning." So, this PR changes the default level of DivisionByZero to "error."

Copy link

Benchmark for 003c06d

Click to view benchmark
Test Base PR %
Array append evaluation 336.1±2.14µs 334.6±2.24µs -0.45%
Array literal evaluation 170.8±1.48µs 174.9±4.87µs +2.40%
Array update evaluation 417.9±3.11µs 418.7±1.70µs +0.19%
Core + Standard library compilation 16.8±0.22ms 16.9±0.51ms +0.60%
Deutsch-Jozsa evaluation 5.0±0.20ms 5.0±0.04ms 0.00%
Large file parity evaluation 33.6±0.16ms 33.6±0.57ms 0.00%
Large input file compilation 11.4±0.13ms 11.5±0.16ms +0.88%
Large input file compilation (interpreter) 44.5±1.40ms 44.4±1.35ms -0.22%
Large nested iteration 32.8±0.16ms 32.8±0.16ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1498.2±41.86µs 1500.5±51.59µs +0.15%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.07ms 7.7±0.06ms -1.28%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1409.7±27.75µs 1417.5±49.16µs +0.55%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.3±0.20ms 21.3±0.17ms 0.00%
Teleport evaluation 81.4±4.14µs 81.2±4.20µs -0.25%

Copy link

Benchmark for 1a1e27f

Click to view benchmark
Test Base PR %
Array append evaluation 338.7±1.77µs 336.5±2.63µs -0.65%
Array literal evaluation 189.6±1.81µs 175.9±4.53µs -7.23%
Array update evaluation 418.2±1.75µs 418.3±2.81µs +0.02%
Core + Standard library compilation 16.8±0.21ms 16.8±0.39ms 0.00%
Deutsch-Jozsa evaluation 5.1±0.05ms 5.0±0.06ms -1.96%
Large file parity evaluation 33.6±0.13ms 33.6±0.40ms 0.00%
Large input file compilation 11.1±0.08ms 11.4±0.14ms +2.70%
Large input file compilation (interpreter) 44.4±1.53ms 44.3±1.24ms -0.23%
Large nested iteration 33.3±0.22ms 32.6±0.23ms -2.10%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1488.9±28.72µs 1490.9±30.82µs +0.13%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.09ms 7.7±0.09ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1402.4±27.67µs 1403.4±23.59µs +0.07%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.2±0.17ms 21.2±0.23ms 0.00%
Teleport evaluation 81.2±5.62µs 80.7±5.57µs -0.62%

Copy link

Benchmark for 9121901

Click to view benchmark
Test Base PR %
Array append evaluation 345.1±11.88µs 350.4±5.65µs +1.54%
Array literal evaluation 190.3±7.13µs 172.7±2.99µs -9.25%
Array update evaluation 424.2±3.87µs 430.0±1.97µs +1.37%
Core + Standard library compilation 19.1±0.58ms 20.3±1.35ms +6.28%
Deutsch-Jozsa evaluation 5.1±0.04ms 5.1±0.04ms 0.00%
Large file parity evaluation 34.0±0.16ms 33.9±0.39ms -0.29%
Large input file compilation 12.4±0.55ms 12.0±0.35ms -3.23%
Large input file compilation (interpreter) 50.9±2.22ms 49.6±1.90ms -2.55%
Large nested iteration 33.4±0.56ms 34.2±0.27ms +2.40%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1527.3±94.82µs 1522.3±75.37µs -0.33%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.1±0.11ms 7.9±0.24ms -2.47%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1433.6±43.70µs 1452.5±80.51µs +1.32%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.8±0.50ms 21.6±0.42ms -0.92%
Teleport evaluation 82.3±4.28µs 81.9±3.89µs -0.49%

Copy link

github-actions bot commented May 1, 2024

Benchmark for ec9af08

Click to view benchmark
Test Base PR %
Array append evaluation 342.9±2.53µs 341.5±3.43µs -0.41%
Array literal evaluation 192.9±7.31µs 173.1±0.77µs -10.26%
Array update evaluation 424.8±1.75µs 423.4±2.27µs -0.33%
Core + Standard library compilation 16.9±0.18ms 16.9±0.25ms 0.00%
Deutsch-Jozsa evaluation 5.1±0.05ms 5.1±0.07ms 0.00%
Large file parity evaluation 33.7±0.10ms 33.7±0.50ms 0.00%
Large input file compilation 11.5±0.32ms 11.5±0.14ms 0.00%
Large input file compilation (interpreter) 47.0±2.13ms 44.7±1.98ms -4.89%
Large nested iteration 33.6±0.13ms 33.5±0.19ms -0.30%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1499.6±30.87µs 1488.2±31.23µs -0.76%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.08ms 7.6±0.08ms -1.30%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1415.0±34.31µs 1411.3±34.52µs -0.26%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.3±0.20ms 21.2±0.25ms -0.47%
Teleport evaluation 83.2±3.98µs 81.6±3.73µs -1.92%

@orpuente-MS orpuente-MS added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit ce5bcf9 May 1, 2024
17 checks passed
@orpuente-MS orpuente-MS deleted the oscarpuente/fix-lint-level branch May 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants