-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate task 1.3 from Measurements to Distinguishing States kata #1489
Conversation
Co-authored-by: Manvi-Agrawal <40084144+Manvi-Agrawal@users.noreply.github.com>
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a couple of small suggestions!
One note, when you're working on a kata that is not published yet, like this one, you need to add it to the list of published katas at index.json to make sure it shows up in the playground and is covered by CI builds. Here's the change I did locally to test it:
Then we remove it as the last thing before merge (I can remove that addition myself when I approve the PR, just want to mention that it needs to be removed, lest we forget to and publish the work prematurely)
Thank you!
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Thank you so much for reviewing - I was able to check in the suggested changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and I checked that it builds fine locally.
Thank you!
Migrating task 1.3 from the Measurements workbook to Distinguishing States Kata.
This resolves a part of the Issue 1185.