Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate task 1.3 from Measurements to Distinguishing States kata #1489

Merged
merged 6 commits into from
May 9, 2024

Conversation

moumita-halder
Copy link
Contributor

Migrating task 1.3 from the Measurements workbook to Distinguishing States Kata.
This resolves a part of the Issue 1185.

  • Added folder plus_minus under distinguishing_states
  • Added index, placeholder, solution, and verification under plus_minus
  • Updated index file under distinguishing_states to contain the exercise plus_minus

@moumita-halder moumita-halder marked this pull request as ready for review May 7, 2024 21:05
moumita-halder and others added 2 commits May 7, 2024 18:33
Co-authored-by: Manvi-Agrawal <40084144+Manvi-Agrawal@users.noreply.github.com>
@moumita-halder
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple of small suggestions!

One note, when you're working on a kata that is not published yet, like this one, you need to add it to the list of published katas at index.json to make sure it shows up in the playground and is covered by CI builds. Here's the change I did locally to test it:

image

Then we remove it as the last thing before merge (I can remove that addition myself when I approve the PR, just want to mention that it needs to be removed, lest we forget to and publish the work prematurely)

Thank you!

moumita-halder and others added 3 commits May 8, 2024 23:41
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@moumita-halder
Copy link
Contributor Author

Thank you so much for reviewing - I was able to check in the suggested changes!
I'll make a note to include the current kata in the list of published katas in index.json, and I'll be sure to mention its removal later on

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and I checked that it builds fine locally.
Thank you!

@tcNickolas tcNickolas changed the title Migrating task 1.3 from Workbook_Measurements to Distinguishing States kata Migrate task 1.3 from Measurements to Distinguishing States kata May 9, 2024
@tcNickolas tcNickolas enabled auto-merge May 9, 2024 04:04
@tcNickolas tcNickolas added this pull request to the merge queue May 9, 2024
Merged via the queue into microsoft:main with commit 1621b26 May 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants