-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tasks 1.5-1.9,1.11 to Distinguishing Unitaries Kata #1572
Add tasks 1.5-1.9,1.11 to Distinguishing Unitaries Kata #1572
Conversation
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…o katas/du-12-13-14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work (and a lot of it too)!! I left some comments but they're mostly formatting/readability improvements.
I also realized that I was too optimistic about removing "from" from the operation names in the first four tasks - once we get to "distinguishing Y from XZ", that convention falls apart... Would you mind going back to the first four tasks and adding "from" to the titles too, so that operation names are uniform across the whole kata?
Thank you!!
This reverts commit 6c9dba7.
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…qsharp into katas/du-15-16-17-18-19-111
This reverts commit 7905e87.
This reverts commit 95f9e13.
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…qsharp into katas/du-15-16-17-18-19-111
This reverts commit ce2c3d6.
…rt Solution change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I verified that the changes to the unpublished kata build and pass the tests locally, so we can merge (and we'll re-run all tests in the PR that publishes it).
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed one unresolved conversation that shows as outdated because of another change in that file: https://github.com/microsoft/qsharp/pull/1572/files/1268f8e311cc0fde90de3a75157eb1dce53d99e9#r1619438948 , to add a reminder of Rz and R1 gates to the description of that task rather than to its solution, same as we did for Rz and Ry in a later task.
Can you please do that final fix before merging this? Thank you!
This resolves part of #1185 .