Support Adjoint invert spec gen via logic separation analysis #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
force-pushed
the
swernli/logic-sep
branch
from
dff0ddb
to
4dac874
Compare
This change introduces logic separation as an analysis pass that returns the set of stmts within a block and all nested scopes that are non-deterministic due to including operation calls. It uses this analysis pass as the chance to collect any errors related to patterns that prevent separation and therefore adjoint generation. This is used by `spec_gen` to support adjoint invert and controlled adjoint invert generation. Includes tests for logic separation analysis and adjoint generation. Note: This does not yet properly handle reversing for-loop expressions as part of inversion. That will be handled in a follow up PR.
swernli
force-pushed
the
swernli/logic-sep
branch
from
87cb2d3
to
1eae23e
Compare
This reverts commit 33940f5.
bamarsha
reviewed
Apr 25, 2023
bamarsha
reviewed
Apr 25, 2023
bamarsha
reviewed
Apr 25, 2023
bamarsha
reviewed
Apr 25, 2023
idavis
reviewed
Apr 25, 2023
bamarsha
reviewed
Apr 26, 2023
bamarsha
reviewed
Apr 26, 2023
bamarsha
reviewed
Apr 26, 2023
bamarsha
approved these changes
Apr 26, 2023
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces logic separation as an analysis pass that returns the set of stmts within a block and all nested scopes that are non-deterministic due to including operation calls. It uses this analysis pass as the chance to collect any errors related to patterns that prevent separation and therefore adjoint generation. This is used by
spec_gento support adjoint invert and controlled adjoint invert generation. Includes tests for logic separation analysis and adjoint generation. This also includes loop reversal of for-loops over ranges and arrays.