[Fabric] Enable ShadowProps for all Fabric Components #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Area: Fabric
TatianaKapos
commented
Sep 5, 2023
| @@ -90,7 +90,7 @@ struct ScrollInteractionTrackerOwner : public winrt::implements< | |||
| void updateContentVisualSize() noexcept; | |||
|
|
|||
| facebook::react::Size m_contentSize; | |||
| winrt::Microsoft::ReactNative::Composition::IVisual m_visual{nullptr}; | |||
| winrt::Microsoft::ReactNative::Composition::ISpriteVisual m_visual{nullptr}; | |||
There was a problem hiding this comment.
@acoates-ms Every other component m_visual was a ISpriteVisual, so changed ScrollView's to match and it seemed to not affect anything on rnTester. Let me know if there was a reason for having this as a IVisual though and I can change it back!
acoates-ms
reviewed
Sep 6, 2023
| @@ -50,6 +50,10 @@ struct CompositionBaseComponentView : public IComponentView, | |||
| void updateBorderProps( | |||
| const facebook::react::ViewProps &oldViewProps, | |||
| const facebook::react::ViewProps &newViewProps) noexcept; | |||
| void updateStyleProps( | |||
There was a problem hiding this comment.
Maybe this should be called updateShadowProps, since that what it seems to handle. -- There are a lot of style props.
There was a problem hiding this comment.
I agree, best to keep them in groupings so we have view components can be more granular about opting-in.
jonthysell
reviewed
Sep 6, 2023
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.cpp
Outdated
Show resolved
Hide resolved
| @@ -50,6 +50,10 @@ struct CompositionBaseComponentView : public IComponentView, | |||
| void updateBorderProps( | |||
| const facebook::react::ViewProps &oldViewProps, | |||
| const facebook::react::ViewProps &newViewProps) noexcept; | |||
| void updateStyleProps( | |||
There was a problem hiding this comment.
I agree, best to keep them in groupings so we have view components can be more granular about opting-in.
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.h
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ImageComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ParagraphComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/SwitchComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Jon Thysell <thysell@gmail.com>
jonthysell
approved these changes
Sep 6, 2023
This was referenced Oct 2, 2023
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finish implementing ShadowProps for other components in Fabric (Text, Image, TextInput, ScrollView, ActivityIndicator, Switch)
Type of Change
Why
Resolves #11754
What
Extracted logic from View Component to Base Component for ShadowProps. Named helper method
updateStylePropsso we can extract more logic in the future.Screenshots
Testing
tested locally!
Changelog
no
Microsoft Reviewers: Open in CodeFlow