Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.73] Revert back to applicationinsights@2.9.1 #12584

Closed
wants to merge 1 commit into from

Conversation

jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Jan 10, 2024

This PR backports #12582 to 0.73.

Description

Fixes a build break introduced by #12575

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

yarn build is broken with this due to a bug in the package that gets run during codegen

What

Revert back to the working version.

Screenshots

N/A

Testing

Ran yarn build

Changelog

Should this change be included in the release notes: no

Description

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Why

What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.

Resolves [Add Relevant Issue Here]

What

What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.

Screenshots

Add any relevant screen captures here from before or after your changes.

Testing

If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.

Optional: Describe the tests that you ran locally to verify your changes.

Changelog

Should this change be included in the release notes: indicate yes or no

Add a brief summary of the change to use in the release notes for the next release.

Microsoft Reviewers: Open in CodeFlow

This PR backports microsoft#12582 to 0.73.

## Description

Fixes a build break introduced by microsoft#12575

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why

yarn build is broken with this due to a bug in the package that gets run during codegen

### What
Revert back to the working version.

## Screenshots
N/A

## Testing
Ran yarn build

## Changelog
Should this change be included in the release notes: no
@jonthysell jonthysell requested review from a team as code owners January 10, 2024 18:13
@jonthysell jonthysell enabled auto-merge (squash) January 10, 2024 18:14
@jonthysell
Copy link
Contributor Author

Unfortunately new 0.73 projects can pull in the new broken Application Insights - this PR locks 0.73 to the latest unbroken version. Since telemetry isn't actually running in this branch, it doesn't really matter that it's locked for the future. If we ever turn it on we'll bump the version then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant