Integration 04/20/24 (03a51da72) #13255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
approved these changes
May 21, 2024
| @@ -419,6 +419,12 @@ bool HermesJSRuntime::supportsConsole() const { | |||
| return false; | |||
| } | |||
|
|
|||
| std::unique_ptr<facebook::react::jsinspector_modern::StackTrace> HermesJSRuntime::captureStackTrace( | |||
There was a problem hiding this comment.
Does this impact our debugging story?
There was a problem hiding this comment.
It shouldn't impact the current debugging story since this is an augmentation. facebook/react-native@4fbc1f2
I've opened #13260 to track adding an actual implementation. Things are a bit tricky at the moment since we forked JSExecutor during the last integration. #13172 is tracking that.
acoates-ms
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
facebook/react-native@1b152f6...03a51da
Integration follow up: #13260
Notable Changes
facebook/react-native@4fbc1f2
facebook/react-native@41a1496
facebook/react-native@0c6fd0a
facebook/react-native@b1576e5
Type of Change
Integration
Microsoft Reviewers: Open in CodeFlow