-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration 04/20/24 (03a51da72) #13255
Conversation
@@ -419,6 +419,12 @@ bool HermesJSRuntime::supportsConsole() const { | |||
return false; | |||
} | |||
|
|||
std::unique_ptr<facebook::react::jsinspector_modern::StackTrace> HermesJSRuntime::captureStackTrace( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this impact our debugging story?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't impact the current debugging story since this is an augmentation. facebook/react-native@4fbc1f2
I've opened #13260 to track adding an actual implementation. Things are a bit tricky at the moment since we forked JSExecutor during the last integration. #13172 is tracking that.
Description
facebook/react-native@1b152f6...03a51da
Integration follow up: #13260
Notable Changes
facebook/react-native@4fbc1f2
facebook/react-native@41a1496
facebook/react-native@0c6fd0a
facebook/react-native@b1576e5
Type of Change
Integration
Microsoft Reviewers: Open in CodeFlow