Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Migrate reactxp's trunk branch from master to main #1221

Open
fbartho opened this issue Jul 22, 2020 · 5 comments
Open

Proposal: Migrate reactxp's trunk branch from master to main #1221

fbartho opened this issue Jul 22, 2020 · 5 comments

Comments

@fbartho
Copy link
Contributor

fbartho commented Jul 22, 2020

We've adopted this in my company for most active repos (some holdouts remain but are currently planned to move eventually), and I personally have adopted this in several open source projects.

There was effort involved in changing the CI tooling, but using main allows engineer's auto-complete muscle memory to keep working, so we found no significant issues.

Some context:

@mikehardy
Copy link
Contributor

Just since I have your ear here, can you list out the exact steps that implement this? I'd changed some other projects to allow/deny but haven't changed git branch terms, and I have other repos I'm interested in regardless of how the proposal goes here

For this specific proposal, I doubt it's a voting thing but I like the change. Technically a non-event but positive on a personal level.

@erictraut
Copy link
Contributor

Github has announced that they're working on processes and tools to help automate this conversion. I think we should wait a little bit longer for the tools and guidance to be published. I agree with the sentiment though, and I fully support this.

@fbartho
Copy link
Contributor Author

fbartho commented Jul 22, 2020

@mikehardy -- the steps I followed was:

  1. Identify & update all use cases of master -- ideally all your CI code is checked into the repo, but you may need to edit files somewhere else.
  2. Do git branch -m master main
  3. Update documentation if necessary
  4. Update Github's Default Branch in Repo Settings
  5. Re-point any open PRs' base branch to main
  6. Delete master if you have no open PRs that you can't adjust

@fbartho
Copy link
Contributor Author

fbartho commented Jul 22, 2020

Super timely announcement right after I posted this proposal: https://github.blog/changelog/2020-07-22-github-actions-better-support-for-alternative-default-branch-names/

@fbartho
Copy link
Contributor Author

fbartho commented Jul 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants