Support for touch gestures on web/GestureView by creating a common base component #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a straight common/GestureView abstract base component, and changed much of the logic away from using raw events as inputs and into the processed RX GestureState types. Pulled a bunch of the duplicate logic out of web/GestureView and used the new base class. Added touchstart/move/end support to web/GestureView to now reuse the touch code out of the common GestureView to get web touch support in GestureView!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to a straight common/GestureView abstract base component, and changed much of the logic away from using raw events as inputs and into the processed RX GestureState types. Pulled a bunch of the duplicate logic out of web/GestureView and used the new base class. Added touchstart/move/end support to web/GestureView to now reuse the touch code out of the common GestureView to get web touch support in GestureView!