Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native-test-app-msal: Add ability to enable broker #900

Open
2 of 5 tasks
tido64 opened this issue Nov 29, 2021 · 0 comments
Open
2 of 5 tasks

react-native-test-app-msal: Add ability to enable broker #900

tido64 opened this issue Nov 29, 2021 · 0 comments
Assignees
@tido64
Labels
enhancement New feature or request feature: sdk This is related to 1RN SDK good first issue Good for newcomers

Comments

@tido64
Copy link
Member

tido64 commented Nov 29, 2021 •
edited
Loading

What happened?

We need the ability to enable the broker:

rnx-kit/packages/react-native-test-app-msal/android/build.gradle

Line 136 in ec46da0

broker_redirect_uri_registered: false,

In order to do that, we also need the ability to configure the keystore in react-native-test-app: microsoft/react-native-test-app#691

Affected Package

react-native-test-app-msal

Version

trunk

Which platforms are you seeing this issue on?

  • Android
  • iOS
  • macOS
  • Windows

System Information

n/a

Steps to Reproduce

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tido64 tido64 added the bug Something isn't working label Nov 29, 2021
@tido64 tido64 mentioned this issue Nov 29, 2021
Merged
5 tasks
@tido64 tido64 changed the title react-native-msal react-native-test-app-msal: Add ability to enable broker Nov 29, 2021
@tido64 tido64 mentioned this issue Jan 6, 2022
Closed
1 task
@tido64 tido64 added enhancement New feature or request feature: sdk This is related to 1RN SDK and removed bug Something isn't working labels May 25, 2023
@kelset kelset added the good first issue Good for newcomers label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tido64 tido64

Labels
enhancement New feature or request feature: sdk This is related to 1RN SDK good first issue Good for newcomers
Projects
rnx-kit
Status: 🌳 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tido64 @afoxman @kelset