[rush] Fix an issue with folder iteration during caching. #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
octogonz and
sachinjoseph
as code owners
octogonz
reviewed
Feb 6, 2022
octogonz
approved these changes
Feb 6, 2022
D4N14L
approved these changes
Feb 6, 2022
iclanton
force-pushed
the
fix-file-collector
branch
from
df1b1ee
to
7644fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, there is an issue with the algorithm that iterates through files that will be passed to
tar. If there are fewer than 10 (the folder iteration concurrency) subfolders inside the folders that are to be cached, folders more than two levels deep will not be iterated through, so their files will not be cached. This happens because the iterator completes before any of the tertiary-level folders are added to the queue.Details
This PR fixes the issue by iterating through each folder level serially instead of trying to add all subfolders to the same queue. This can result in slightly less parallelism, but it will always capture all folders.
How it was tested
Tested on a project with four subfolders inside its
libfolder and files more than three levels deep that produced cache entries that are missing files.