[rush] Add support for subspaces in rush check #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william2958
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
octogonz
reviewed
May 15, 2024
common/changes/@microsoft/rush/will-subspace-patch-25_2024-05-14-21-13.json
Outdated
Show resolved
Hide resolved
…14-21-13.json Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
octogonz
reviewed
May 15, 2024
common/changes/@microsoft/rush/will-subspace-patch-25_2024-05-14-21-13.json
Outdated
Show resolved
Hide resolved
…14-21-13.json Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
octogonz
reviewed
May 15, 2024
common/changes/@microsoft/rush/will-subspace-patch-25_2024-05-14-21-13.json
Outdated
Show resolved
Hide resolved
…14-21-13.json Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
octogonz
reviewed
May 15, 2024
libraries/rush-lib/src/api/test/__snapshots__/RushCommandLine.test.ts.snap
Outdated
Show resolved
Hide resolved
octogonz
reviewed
May 15, 2024
|
This change requires updating the website docs. You don't need to do the work, but your PR needs to let us know. (Filling out that section is supposed to automatically open a GitHub issue in the docs repo.) |
octogonz
reviewed
May 23, 2024
octogonz
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the "rush check" command does not support subspace scoping, rather running for the entire monorepo at once. This MR adds the
--subspaceCLI parameter to therush checkcommand.Details
See design note #4720
How it was tested
Tested by running
rush change --subspace defaultin a subspace enabled monorepo.Impacted documentation
This MR impacts the following documentation, as their CLI parameters have changed:
https://rushjs.io/pages/commands/rush_check/
https://rushjs.io/pages/commands/rush_version/