[rush] Add a --network-concurrency option for troubleshooting network issues #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
reviewed
Aug 10, 2018
|
|
||
| /** | ||
| * The value of the "--network-concurrency" command-line parameter, which | ||
| * is a diagnostic option used to troubleshoot network failures. |
There was a problem hiding this comment.
I'd mention this is PNPM-specific here as well. #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have occasionally been reporting "integrity checksum failed" errors during PNPM install, which result from an ECONNRESET error that seems to be related to an issue with the network connection pool. (See pnpm/pnpm#1230 for details.)
We found that specifying PNPM's
--network-concurrency 1option eliminates the error (but increases install times). This PR exposes this switch torush installso we can use it as a workaround. We will experiment with different values and perhaps propose applying a default maximum for the PNPM tool.