Remove unused AAD token to support other identity providers #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring the AAD token produces error when using other identity providers, such as those using OpenID. Moreover, the AAD token (X-Ms-Token-Aad-Id-Token) is not used anywhere in the app.
sarah-widder
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Thank you for the contribution! Rather than removing these fields, in case they might be used in future features, let's just change them to .get() calls instead of directly reading the properties. That will make it flexible for other identity providers while preserving these values for AAD in case they will be needed.
sarah-widder
approved these changes
Jan 8, 2024
|
Thank you for the proposal, your patience, and the quick approval, Sarah. |
LandMagic
added a commit
to ciesko/msrchat
that referenced
this pull request
Jan 16, 2024
* - supporting docx and pptx in offline ingestion script via form recognizer (microsoft#474) Co-authored-by: FARHAD SHAKERIN <fxs130430@utdallas.edu> * Change button colors (microsoft#462) * Fix comma/pipe separator issue and improve local dev loop (microsoft#483) Co-authored-by: Sarah Widder <sawidder@microsoft.com> * Remove unused AAD token to support other identity providers (microsoft#459) * [Feature] Rebrand sample app with Contoso branding (microsoft#486) Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com> * Add feedback buttons with optional setting (microsoft#396) Co-authored-by: Sarah Widder <sawidder@microsoft.com> Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com> * Rebuild static files (microsoft#491) Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com> * remove linting errors * merge fix complete * remove hard-coded api-preview-version * remove addition to cosmosdb key * remove print plus small json fix * additional format and var fixes * fix another typo * restore location of dotenv and logging --------- Co-authored-by: FARHAD SHAKERIN <shakerin.farhad@gmail.com> Co-authored-by: FARHAD SHAKERIN <fxs130430@utdallas.edu> Co-authored-by: vsunnyzhao <154259069+vsunnyzhao@users.noreply.github.com> Co-authored-by: Sarah Widder <sarah.j.widder@gmail.com> Co-authored-by: Sarah Widder <sawidder@microsoft.com> Co-authored-by: Christoph Goessmann <44035999+gochristoph@users.noreply.github.com> Co-authored-by: Ian Seabock <iseabock@users.noreply.github.com> Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com> Co-authored-by: Chana <v-chanacohn@microsoft.com>
sudo-init
pushed a commit
to sudo-init/sample-app-chatGPT
that referenced
this pull request
Sep 20, 2024
nikhilnagaraj
pushed a commit
to Admin-bh-Edge/Edge-Comp-Policies
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
Requiring the key
X-Ms-Token-Aad-Id-Tokeneffectively requires using AAD/Microsoft as identity provider and produces and error and the loss of chat history with other identity providers.Removing the dependency in
auth_utils.pyas the AAD token is not used anywhere in the app.This fixes the dependency on AAD and allows other identity providers, such as OpenID, to be used.
Ready for review.