Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image for async refactor, use new ACR #625

Merged
merged 6 commits into from
Feb 17, 2024

Conversation

sarah-widder
Copy link
Contributor

@sarah-widder sarah-widder commented Feb 17, 2024

Motivation and Context

#460 refactored the backend to use ASGI, while the docker container was still using WSGI. This caused new images after that change to fail to start with the old dockerfile.

Description

From @iseabock

  • Update WebApp.Dockerfile to use gunicorn CMD
  • Update requirements.txt to include gunicorn

From @sarah-widder

  • Update workflow to push to a new ACR, to avoid unintentionally breaking apps using the pre-refactor container.
  • Update 'Deploy to Azure' ARM template to point to the new ACR.

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

Copy link
Contributor

@iseabock iseabock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sarah-widder sarah-widder merged commit 31dbce2 into main Feb 17, 2024
1 check passed
@sarah-widder sarah-widder deleted the 26677630-docker-fix branch February 17, 2024 01:07
sudo-init pushed a commit to sudo-init/sample-app-chatGPT that referenced this pull request Sep 20, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants