Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Boolean to sanitize answers in the frontend #693

Merged

Conversation

iseabock
Copy link
Contributor

Motivation and Context

It was noted that a request that required a response with html in would not display properly. Particularly that html, head, and body tags were stripped out of the response.

Description

The behavior described above was caused by the sanitize method in the DOMPurify package. Since there is a possibility one would want to sanitize answers there is now an environment variable to toggle this behavior.

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

@iseabock iseabock self-assigned this Mar 11, 2024
Copy link
Contributor

@sarah-widder sarah-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@iseabock iseabock merged commit e9fc0ae into main Mar 13, 2024
1 check passed
@iseabock iseabock deleted the feature-26972916-add-bool-sanitize-frontend-setting-for-Answer branch March 13, 2024 00:48
sudo-init pushed a commit to sudo-init/sample-app-chatGPT that referenced this pull request Sep 20, 2024
)

Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
)

Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants