Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sanitize links #944

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Do not sanitize links #944

merged 3 commits into from
Jun 20, 2024

Conversation

iseabock
Copy link
Contributor

Motivation and Context

User noted DomPurify was sanitizing links in citations replacing & with &

Description

This PR adds an allowed attributes array that has href to skip sanitizing hrefs

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

Ian Seabock (Centific Technologies Inc) added 2 commits June 20, 2024 14:35
@iseabock iseabock changed the title No task do not sanatize links Do not sanitize links Jun 20, 2024
@iseabock iseabock merged commit e9c8954 into main Jun 20, 2024
8 checks passed
@iseabock iseabock deleted the NO-TASK-do-not-sanatize-links branch June 20, 2024 23:28
sudo-init pushed a commit to sudo-init/sample-app-chatGPT that referenced this pull request Sep 20, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants