Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe DATASOURCE_TYPE & enable prompt flow even when AZURE_OPENAI_STREAM=true #991

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

DOliana
Copy link
Contributor

@DOliana DOliana commented Jul 6, 2024

Motivation and Context

2 things:

  • the documentation did not properly describe the variable DATASOURCE_TYPE
  • prompt flow currently does not work, if AZURE_OPENAI_STREAM is set to true (probably the reason of Cannot use a deployed prompt flow in web app #934, since AZURE_OPENAI_STREAM defaults to true)

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • I didn't break any existing functionality 😄

Copy link
Member

@abhahn abhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for catching these issues and fixing them.

@abhahn
Copy link
Member

abhahn commented Jul 10, 2024

Hi @DOliana , just wanted to let you know that I pulled your changes to my local and ran the integration tests locally and they all pass without any issues. I think the problem with the integration tests is related to this documented limitation of workflow secrets being unavailable when running workflows for PRs from forked repositories: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

I can bypass this check for now to get the PR merged.

@abhahn abhahn merged commit 6bc2752 into microsoft:main Jul 10, 2024
8 of 9 checks passed
@DOliana DOliana deleted the improve-readme branch July 11, 2024 07:52
sudo-init pushed a commit to sudo-init/sample-app-chatGPT that referenced this pull request Sep 20, 2024
…STREAM=true (microsoft#991)

Co-authored-by: Denis Oliana <denis.oliana@microsoft.com>
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
…STREAM=true (microsoft#991)

Co-authored-by: Denis Oliana <denis.oliana@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants