Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multitool page command should return option errors without throwing #1629

Closed
ghost opened this issue Aug 8, 2019 · 0 comments
Closed

Multitool page command should return option errors without throwing #1629

ghost opened this issue Aug 8, 2019 · 0 comments
Labels
area-multitool Multitool command implementations design-improvement

Comments

@ghost
Copy link

ghost commented Aug 8, 2019

In the page command, if the user specifies invalid values for the runIndex, index, or count options, or the the input file path, it throws, and the user has to dig the useful information out of an exception dump. Just print the message to the console and return non-zero (as we now do for the call to DriverUtilities.ReportWhetherOutputFileCanBeCreated).
@ghost ghost added design-improvement area-multitool Multitool command implementations labels Aug 8, 2019
@ghost ghost self-assigned this Aug 19, 2019
ghost pushed a commit that referenced this issue Aug 19, 2019
Fix #1629: Page command shouldn't throw on options error.
287061b
@ghost ghost mentioned this issue Aug 19, 2019
Merged
@ghost ghost closed this as completed in eb34625 Aug 21, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-multitool Multitool command implementations design-improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants