Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work item filer not logging work item detail metrics #1896

Closed
ghost opened this issue Jun 2, 2020 · 0 comments · Fixed by #1893
Closed

Work item filer not logging work item detail metrics #1896

ghost opened this issue Jun 2, 2020 · 0 comments · Fixed by #1893
Assignees
@eddynaka
Labels
bug resolved-fixed

Comments

@ghost
Copy link

ghost commented Jun 2, 2020

WorkItemFiler.cs is populating workItemDetailMetrics, but then logging workItemMetrics for a second time instead of logging workItemDetailMetrics.
@ghost ghost added the bug label Jun 2, 2020
@ghost ghost assigned eddynaka Jun 2, 2020
@ghost ghost closed this as completed in de3ff52 Jun 2, 2020
@ghost ghost added the resolved-fixed label Jun 2, 2020
@eddynaka eddynaka linked a pull request Jun 2, 2020 that will close this issue
updating SarifWorkItemFiler to use the correct variable #1893
Merged
eddynaka added a commit that referenced this issue Jun 2, 2020
@eddynaka
adding #1896 issues to readme
fb2d6f8
eddynaka added a commit that referenced this issue Jun 2, 2020
@eddynaka
Adding schema validation
d132c60 
Changing from AbsolutePath to OriginalString, since sometimes its null;
Updating SARIF1015 test, including SARIF1020 output

updating tests

updating file name, updating resource file

updating release history file

renaming to referToFinalSchema

updating logresults argunments

adding #1896 issues to readme

updating test files
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddynaka eddynaka

Labels
bug resolved-fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updating SarifWorkItemFiler to use the correct variable microsoft/sarif-sdk
1 participant
@eddynaka