Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1575: SarifSdkTest.xml conversion test does not run. #1646

Merged
2 commits merged into from
Aug 15, 2019
Merged

Fix #1575: SarifSdkTest.xml conversion test does not run. #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5957ff
Fix #1575: SarifSdkTest conversion test does not run
Aug 14, 2019
7edc8e4
Update release history.
Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ReleaseHistory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,5 +445,6 @@
* FEATURE: Add validation rule to ensure that all array-index-valued properties are consistent with their respective arrays.

** **v2.1.15** [Sdk](https://www.nuget.org/packages/Sarif.Sdk/2.1.15) | [Driver](https://www.nuget.org/packages/Sarif.Driver/2.1.15) | [Converters](https://www.nuget.org/packages/Sarif.Converters/2.1.15) | [Multitool](https://www.nuget.org/packages/Sarif.Multitool/2.1.15)
* BUGFIX: Restore missing FxCop converter unit test. https://github.com/microsoft/sarif-sdk/issues/1575
* BUGFIX: FortifyFpr converter produced invalid SARIF. https://github.com/microsoft/sarif-sdk/issues/1593
* BUGFIX: FxCop converter produced empty `result.message` objects. https://github.com/microsoft/sarif-sdk/issues/1594
27 changes: 12 additions & 15 deletions src/Test.FunctionalTests.Sarif/Test.FunctionalTests.Sarif.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2816,6 +2816,12 @@
<None Include="v2\ConverterTestData\FxCop\FxCopNoTargets.xml.sarif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="v2\ConverterTestData\FxCop\SarifSdkTest.fxcop.sarif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="v2\ConverterTestData\FxCop\SarifSdkTest.xml.sarif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
<ItemGroup>
<None Include="v2\SpecExamples\Comprehensive.sarif">
Expand Down Expand Up @@ -2906,6 +2912,12 @@
<None Include="v2\ConverterTestData\FxCop\FxCopNoTargets.xml">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="v2\ConverterTestData\FxCop\SarifSdkTest.fxcop">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="v2\ConverterTestData\FxCop\SarifSdkTest.xml">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
<ItemGroup>
<None Include="v2\ConverterTestData\ClangAnalyzer\ArrayDataTypes.xml">
Expand Down Expand Up @@ -3552,21 +3564,6 @@
<Generator>TextTemplatingFileGenerator</Generator>
<LastGenOutput>bannedAPIs.cs</LastGenOutput>
</None>
<None Update="v2\ConverterTestData\FxCop\SarifSdk.fxcop.sarif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="v2\ConverterTestData\FxCop\SarifSdk.xml">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="v2\ConverterTestData\FxCop\SarifSdk.xml.sarif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="v2\ConverterTestData\FxCop\SarifSdkTest.fxcop.sarif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="v2\ConverterTestData\FxCop\SarifSdkTest.xml.sarif">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="v2\ConverterTestData\PREfast\AB_IrrelevantBranch.cpp.xml">
<Generator>TextTemplatingFileGenerator</Generator>
<LastGenOutput>AB_IrrelevantBranch.cpp.cs</LastGenOutput>
Expand Down
1 change: 0 additions & 1 deletion src/Test.FunctionalTests.Sarif/v2/ConverterTestData/FxCop/FxCopExceptions-test.sarif
View file
Open in desktop

This file was deleted.

Loading