NOT WORKING Extract Sarif.Multitool.Library from Sarif.Multitool #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 1, 2020 11:05
ghost
commented
Sep 1, 2020
| @@ -13,8 +13,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Multitool | |||
| { | |||
| public abstract class CommandBase | |||
| { | |||
| internal const int SUCCESS = 0; | |||
| internal const int FAILURE = 1; | |||
| public const int SUCCESS = 0; | |||
There was a problem hiding this comment.
public [](start = 8, length = 6)
Needs to be public for the sake of Program in Sarif.Multitool.
ghost
commented
Sep 1, 2020
| @@ -160,7 +160,7 @@ internal class MultitoolResources { | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Looks up a localized string similar to No security token was provided. Populate the 'SarifWorkItemFilingSecurityPat' environment variable with a valid personal access token or pass a token in a configuration file using the --configuration option. | |||
| /// Looks up a localized string similar to No security token was provided. Populate the 'SarifWorkItemFilingPat' environment variable with a valid personal access token or pass a token in a configuration file using the --configuration option. | |||
There was a problem hiding this comment.
Pat [](start = 123, length = 3)
I don't know why this changed. I didn't touch the resources in this PR.
ghost
changed the title
|
Replaced by #2054. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.